Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wt.exe should accept env vars on the commandline #16008

Open
2 tasks
Tracked by #4632
zadjii-msft opened this issue Sep 20, 2023 · 0 comments
Open
2 tasks
Tracked by #4632

wt.exe should accept env vars on the commandline #16008

zadjii-msft opened this issue Sep 20, 2023 · 0 comments
Labels
Area-Commandline wt.exe's commandline arguments Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@zadjii-msft
Copy link
Member

forked from #15496

wt -E foo=bar to manually pass env vars to the NewTerminalArgs. This'll let a caller manually pass env vars on the commandline. Great!

builds off the work in #15082. Basically, each of the -E foo=bar args would get collected by the arg parser, then eventually passed to TerminalSettings::CreateWithNewTerminalArgs. We'd layer them on top of anything from the profile.

open questions:

  • syntax?
  • What if I want to pass -E foo=%bar%, where bar is something defined in the profile's env block, but not the current one?
    • IMO we can just say no to this. This seems impossible, and also why?
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Commandline wt.exe's commandline arguments labels Sep 20, 2023
@zadjii-msft zadjii-msft added this to the Backlog milestone Sep 20, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 20, 2023
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Commandline wt.exe's commandline arguments Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants