Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow ctrl-v to be overriden #16280

Closed
pm100 opened this issue Nov 7, 2023 · 5 comments
Closed

allow ctrl-v to be overriden #16280

pm100 opened this issue Nov 7, 2023 · 5 comments
Assignees
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Discussion Something that requires a team discussion before we can proceed Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@pm100
Copy link

pm100 commented Nov 7, 2023

Description of the new feature/enhancement

Today regardless of any mode settings ctrl-v is always processed by terminal rather than passing it to the app. This is not convenient because:

  • maybe ctrl-v means something else to the app
  • asymmetry, ctrl-c is passed to the app if ENABLE_PROCESSED_INPUT is off but ctrl-v is not. If I have my own 'clipboard' then the ctrl-v will paste the wrong text
  • with multi line pastes I get a popup dialog warning me (imagine if vs code did this on every paste)
  • The paste comes in as separate keys strokes, not as one operation, so if I support undo then on a 50 char paste I have to press undo 50 times
  • the ctrl-v paste is slow since the app sees it as multiple keystrokes rather than one large insert
  • A large paste might even overflow my undo history stack so its not undoable at all

Others have reported this issue and all the suggestions and proposed solutions are not really useful

  • change the keyboard settings. Problem is that I want ctrl-v to work elsewhere, on the command line say
  • terminal detects the name of the executable (vim.exe), this is plainly not workable
  • only needed for WSL - not enough

Proposed technical implementation details (optional)

either

  • ENABLE_PROCESSED_INPUT=0 should disable ctrl-v as well as ctrl-c. This is a theoretically breaking change
  • a new DONT_PASTE flag in console mode settings
@pm100 pm100 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 7, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 7, 2023
@DHowett
Copy link
Member

DHowett commented Nov 7, 2023

Today regardless of any mode settings ctrl-v is always processed by terminal
Others have reported this issue and all the suggestions and proposed solutions are not really useful

  • change the keyboard settings. Problem is that I want ctrl-v to work elsewhere, on the command line say

Would you be able to elaborate on this? Deleting the Ctrl+V key binding from Windows Terminal's settings is quick and easy, and doesn't require you to change any keyboard configuration.

Thanks!

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 7, 2023
@pm100
Copy link
Author

pm100 commented Nov 7, 2023

I only want it for the app I am writing (just like vim, nano,... that have also complained about the same thing) not globally. ie the app needs to turn it on and off, just like I can turn ctrl-c on and off programmatically. It should not have to be :

  • a global change
  • done by the end user

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 7, 2023
@carlos-zamora carlos-zamora added the Needs-Discussion Something that requires a team discussion before we can proceed label Nov 8, 2023
@j4james
Copy link
Collaborator

j4james commented May 3, 2024

See also #11267

@zadjii-msft
Copy link
Member

You know what? You're absolutely right. This is a /dupe of #11267. We'll consolidate tracking there, thanks!

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2024
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements Needs-Attention The core contributors need to come back around and look at this ASAP. labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Discussion Something that requires a team discussion before we can proceed Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

5 participants