Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Terminal text overlaps in some GB18030-2022 Chinese Standard Code Characters #16779

Open
testforstephen opened this issue Feb 28, 2024 · 1 comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone

Comments

@testforstephen
Copy link

testforstephen commented Feb 28, 2024

Windows Terminal version

1.19.10573.0

Windows build number

10.0.22621.3155

Other Software

No response

Steps to reproduce

  • Change System Locale to Chinese (Simplified, China) and Restart your machine
    • Control Panel -> Clock & Region -> Region (Administrative) -> Change system locale to Chinese (Simplified, China)
  • New a Windows Terminal of PowerShell/cmd (The default chcp code page is 936 according to the system locale)
  • Copy some GB18030-2022 Chinese Standard Code Characters ①Ⅻㄨㄩ啊阿鼾齄丂丄狚狛狜狝﨨﨩ˊˋ˙–⿻〇 to the terminal and verify if the test character set can be rendered well.

Expected Behavior

Each character can be rendered individually in the terminal.

Actual Behavior

Both PowerShell and cmd have some glyphs overlapping.

image

@testforstephen testforstephen added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 28, 2024
@lhecker
Copy link
Member

lhecker commented Feb 28, 2024

Just for documentation, I'd like to state it here as well: In the past we found that scaling down glyphs is generally unexpected. It broke a lot of terminal applications and resulted in a lot of complaints. (In particular when we did it for glyphs commonly used in powerline-like prompts).

The fundamental problem here is that ① and Ⅻ are "ambiguous width" glyphs and we treat those as "narrow" (= 1 cell wide) by default. The reason for that is explained in #2066 and boils down to: All modern terminal applications expect it.
The way I see it, we can address your issue only in one way: By adding an opt-in setting to treat all ambiguous width glyphs as wide glyphs (= "full-wdth" = 2 cells wide). See issue #153 for this.

This means, Windows Terminal will continue to have overlapping glyphs in the future by default.

@carlos-zamora carlos-zamora added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 28, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants