Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker stats flickers #1680

Closed
ahmelsayed opened this issue Jun 27, 2019 · 11 comments
Closed

docker stats flickers #1680

ahmelsayed opened this issue Jun 27, 2019 · 11 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@ahmelsayed
Copy link
Member

ahmelsayed commented Jun 27, 2019

Environment

Windows build number: 10.0.18922.1000
Windows Terminal version (if applicable): 0.2.1715.0

Any other software? WSL2, zsh, docker

Steps to reproduce

docker run --rm -d alpine sleep 20s
docker run --rm -d alpine sleep 20s
docker stats

Expected behavior

On GNOME Terminal the output is displayed without flickering.

Actual behavior

On Windows Terminal it flickers.

I tried to record a GIF, but my screen recorder doesn't show the flickering. It only records at 10 fps though.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 27, 2019
@ahmelsayed ahmelsayed changed the title docker stat flickers docker stats flickers Jun 27, 2019
@JushBJJ
Copy link

JushBJJ commented Jun 27, 2019

Does it flicker with the old cmd? If it does still then report the issue at the WSL repo.

@miniksa
Copy link
Member

miniksa commented Jun 27, 2019

Record with your smartphone and upload a video?

@miniksa miniksa added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 27, 2019
@ahmelsayed
Copy link
Member Author

ahmelsayed commented Jun 27, 2019

https://ahmelsayed.blob.core.windows.net/public/IMG_0144.mp4

The first is Windows Terminal, then I switch the KVM to a linux box running GNOME Terminal.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 27, 2019
@thorerik
Copy link

I wonder if this is related to the draw performance in general?
It can also be observed by running, e.g. sudo yast2 on OpenSuSE Leap 15.1 in WSL:
In Terminal:
ezgif-2-c671632045b9

In standard conhost:
ezgif-2-a20ef2dbfce1

the issue becomes more apparent when running the terminal emulator in a larger size.

@JushBJJ
Copy link

JushBJJ commented Jun 28, 2019

That's quite weird. I think it has to do something with the rendering that makes it flicker.

@DHowett-MSFT
Copy link
Contributor

Until proven otherwise, I'll dupe this to #778. Thanks for all the cool repro cases!

@DHowett-MSFT DHowett-MSFT added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jul 1, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 1, 2019
@DHowett-MSFT DHowett-MSFT removed Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 1, 2019
@skyline75489
Copy link
Collaborator

@miniksa I'm gonna comment here so it does not mess with the pile of comments in #5185.

I've also seen this with iTerm2 on macOS when I'm in a SSH session on remote machines and the network is slow. The routine of docker stats is basically repainting all the stats to the screen over and over again. Natually it should flicker if the duration between each painting is noticeably long. I begin to doubt that this is rendering-related. We can improve rendering performance for sure. But the docker stats may still be flickering, even in iTerm2.

@miniksa
Copy link
Member

miniksa commented Apr 12, 2020

@skyline75489, OK. I might not worry that hard about it right now then and just get the differential work in and let a future issue be opened fresh if there is still a real problem. Thanks!

@tu-nv
Copy link

tu-nv commented Sep 30, 2020

@miniksa In my case, New Terminal has a serious flickering issue that makes docker stats not usable, but the wsltty (https://github.com/mintty/wsltty) does not have that issue. I am running win 10, terminal preview Version: 1.4.2652.0. And yes, I do ssh to another machine and fire tmux there, open docker stats in one tmux panel.

@jherico
Copy link

jherico commented May 5, 2021

I found this and after reading through the linked comments I think this is really a docker stats issue rather than a windows termainl issue. I was able to reproduce it on ConEmu.

@ClassicDarkChocolate
Copy link

I found that when I right click on tab to open context menu. When the context menu is in open state, the terminal updates screen without flickering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

9 participants