-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent terminal color (on startup) #16996
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
Could you share your settings.json file/? |
Of course! Here: settings.json |
Thanks for filing! We took a look at the settings.json file and nothing stood out. Could you capture a Debug Tap of when the terminal launches with this unexpected configuration/? Be sure to hold both alt buttons when the terminal launches to get it to work. |
I've activated the debug trap now, but I was not able to immediately reproduce the issue. It comes every now and then for me, I'll post here as soon as I catch one! |
I have so far been unable to reproduce the bug with the debug tap active. I will keep trying for a while longer, but maybe the bug does not show up with the tap active? |
But it does show up relatively consistently without the debug tap? That would be.... extremely bizarre. Especially since the color values in the image don't actually look like they're coming from the color schemes, so that would seemingly suggest that there's something in your prompt that's manually emitting those colors? |
Yes, it happens multiple times per day, but I have not yet figured out a way to reliably reproduce it. Mostly I think it's when I leave the computer on for a while and the screen goes dark after screen lock (e.g. during lunch). When I come back, it's very frequent that this problem occurs. Next time I catch it, I'll try to echo a color (e.g. I'll do my best to try and figure out the exact circumstances. Will keep you posted! |
Just FYI: I'll get back whenever I have new info. If this is automatically closed, I'll just reopen it. 👍 |
Thanks! If you don't have the rights to reopen it, let one of us know and we will! |
The image you shared has a background color of
I think this may be a memory corruption of our color table(s). |
Yes, at least in my understanding. DWM composites all applications into a single surface which has a color format and space that fits the target display. Windows Terminal renders text into a BGR (reverse RGB) 8-bit surface, which DWM composites into for instance (I'm not actually sure which one specifically) RGB with 16-bit floats to later output it on a HDR display. When you take a screenshot, it'll take a copy from that DWM surface and then convert it back to 8-bit RGB.
GPUs should apply color profiles very late with a matrix or LUT transform, only when actually sending the image to the monitor. I was just wondering if it's possible that a color profile may get applied early by DWM and if so, if it may not be applied to all swap chains (= all panes/tabs). I don't think that's possible, but... Well maybe it's indeed a memory corruption. But it'd definitely be the first and only report about it so far! |
Windows Terminal version
1.19.10573.0
Windows build number
10.0.22631.0
Other Software
master (0fed366)
ZSH_THEME="bira"
Steps to reproduce
I cannot reproduce it 100% reliably, but I do get it fairly regularly (at least once per day).
It typically happens for the first terminal I create after I boot my computer.
Expected Behavior
If I open multiple panes/tabs/windows, they should all have the same colorscheme (or render the colors the same way).
Actual Behavior
For the first terminal I create, I get colors that are slightly off. All panes/tabs/windows I create after that have correct colors:
In this example, the upper pane is the first pane and the lower pane was created later.
According to the color picker from PowerToys, these are the colors I get in the screenshot example:
#0c0c0c
#f0f0f0
#4be14b
#4040bd
#0c0c0c
#f0f0f0
#15b40c
#3b78ff
Node that there is some variation caused by aliasing, so I may have accidentally picked the wrong colors. But it's an honest attempt. 😅
The text was updated successfully, but these errors were encountered: