Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21] Hot reloading to set a newly-installed font doesn't work #17034

Open
DHowett opened this issue Apr 9, 2024 · 1 comment
Open

[1.21] Hot reloading to set a newly-installed font doesn't work #17034

DHowett opened this issue Apr 9, 2024 · 1 comment
Labels
Area-Fonts Related to the font Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.22

Comments

@DHowett
Copy link
Member

DHowett commented Apr 9, 2024

Windows Terminal version

1.21

Windows build number

No response

Other Software

No response

Steps to reproduce

Install a new font.

Set it as the font.

Save settings.

Expected Behavior

No response

Actual Behavior

You'll get one error dialog per open terminal, and they'll switch to Consolas.

Newly-opened panes will use the specified font.
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 9, 2024
@lhecker
Copy link
Member

lhecker commented Apr 9, 2024

It may be necessary for us to specify TRUE for GetSystemFontCollection. However, we probably don't want to do that in the startup path. Additionally, we already do that in the settings editor code so I wonder why it doesn't get triggered. Maybe it's because UpdateFontList() doesn't get called again.

@carlos-zamora carlos-zamora added Area-Fonts Related to the font Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 10, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.21 milestone Apr 10, 2024
@lhecker lhecker mentioned this issue Apr 11, 2024
Closed
@lhecker lhecker modified the milestones: Terminal v1.21, Terminal v1.22 May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Fonts Related to the font Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.22
Development

No branches or pull requests
4 participants
@DHowett @lhecker @carlos-zamora and others