Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Command's knowledge of its own keybindings #17160

Open
PankajBhojwani opened this issue Apr 30, 2024 · 0 comments
Open

Remove Command's knowledge of its own keybindings #17160

PankajBhojwani opened this issue Apr 30, 2024 · 0 comments
Assignees
@PankajBhojwani
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.22

Comments

@PankajBhojwani
Copy link
Contributor

Description of the new feature/enhancement

As we move to implementing Action IDs and referring to Commands with their IDs everywhere, it no longer makes sense for a Command to have knowledge about its own keymappings (let the Action Map handle that, especially with all the layering involved)

Proposed technical implementation details (optional)

Remove the keymappings array from Command, currently every place that we query a Command for its keys also has access to the ActionMap, so those places should query the ActionMap for the keys of that Command instead
@PankajBhojwani PankajBhojwani added the Issue-Task It's a feature request, but it doesn't really need a major design. label Apr 30, 2024
@PankajBhojwani PankajBhojwani self-assigned this Apr 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Apr 30, 2024
@PankajBhojwani PankajBhojwani added Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements labels Apr 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 30, 2024
@PankajBhojwani PankajBhojwani added the Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. label Apr 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 30, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 1, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.22 milestone May 1, 2024
@PankajBhojwani PankajBhojwani mentioned this issue May 8, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.22
Development

No branches or pull requests
2 participants
@carlos-zamora @PankajBhojwani