Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause and resume execution of left- and right-click like in PowerShell #17176

Closed
github-account1111 opened this issue May 2, 2024 · 7 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@github-account1111
Copy link

github-account1111 commented May 2, 2024

Description of the new feature/enhancement

I googled and searched through issues but couldn't find anything about this.

On Windows 10 I could left-click anywhere inside the PowerShell window, and the execution would pause. I knew the execution was paused when the title bar said "Select PowerShell." When I was ready to resume the execution I just needed to right-click anywhere on the window.

This incredibly handy feature seems to be missing in Microsoft Terminal's PowerShell on Windows 11. Now I have to either wait for the execution to finish (which depending on what I'm running could take hours) or cancel it entirely.

Proposed technical implementation details (optional)

Same as on Windows 10.

@github-account1111 github-account1111 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 2, 2024
@zadjii-msft
Copy link
Member

Is the end goal here to actually suspend the CLI application that's running connected to the Terminal, or just make it easier to select text in the scrollback/?

There's some related discussion in:

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 2, 2024
@github-account1111
Copy link
Author

github-account1111 commented May 2, 2024

It's the former. It's strange to me that most participants of those issues seem to only be interested in the latter.

Especially that second one. It's not a bug, it's the default PowerShell behavior. It doesn't "freeze." As I mentioned in the description, you can easily tell if it's active or not by looking at the title bar.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 2, 2024
@zadjii-msft
Copy link
Member

Well, it's technically correct that it doesn't "freeze". But selecting in the vintage console prevents conhost from servicing any further console API calls. It just blocks the call until the selection is dismissed. That effectively pauses powershell (or any other CLI app) that's waiting on writing before continuing.

I'm guessing for most people (myself included) are just happy that selecting the Terminal accidentally doesn't entirely pause long builds anymore. I could have sworn there was an issue floating around asking for the ability to manually pause the conpty client, but I can't find anything like that now...

@github-account1111
Copy link
Author

github-account1111 commented May 2, 2024

What's the issue with that behavior? You can just right-click to resume. Takes less than a second. Meanwhile potentially hours are wasted waiting for execution to finish, or execution has to be cancelled entirely. It also helps avoid overheating, especially if you use laptops or external drives.

You're basically eliminating a tiny little inconvenience (I even struggle to call it that, it's that inconsequential so long as you bother to look at the title bar) at the cost of quite a lot of fundamental functionality and usefulness.

@lhecker
Copy link
Member

lhecker commented May 2, 2024

Maybe you already know, but...

Actually you can still pause the output at any time: Just press the "Pause" or "Break" key. 😅 Almost all modern hardware and operating systems use the Pause/Break key for pausing terminal output. It's usually in the top right, above the Delete and Insert keys, if you have a full sized keyboard. If you don't have a Pause/Break key you can press Ctrl+S instead. On the latest Windows Terminal versions both should pause/freeze the output immediately until you press another key.

If you did already know that the Pause key does this, can you explain why it doesn't work for you?

@lhecker
Copy link
Member

lhecker commented May 2, 2024

You're basically eliminating a tiny little inconvenience (I even struggle to call it that, it's that inconsequential so long as you bother to look at the title bar) at the cost of quite a lot of fundamental functionality and usefulness.

Oh and... For what it's worth, I'm personally not opposed to implementing your suggestion, and I think you make an excellent argument for this feature. In fact I often did this myself (selecting to pause output), before I learned that the Pause key can be used for this.

However, we currently can't easily implement it correctly for architectural reasons (the entire ConPTY setup). It's certainly possible, for instance by sending a pause key press when selection starts and when it ends, but that's obviously going to be very error prone. For example, if someone had already paused output, or if we miss a key press somehow, or someone injects the pause key via the console APIs, in all those cases the thing the PTY sees and what Windows Terminal sees would get out of sync and you'd never be able to properly unpause the output anymore.

Given that other terminals don't seem to have this behavior, nor make it configurable, and that virtually all terminals support the Pause key and its Ctrl+S alias, I think this feature request may be too risky in my personal opinion.

@carlos-zamora
Copy link
Member

Thanks for the feedback. As stated above, this is a bit risky of a change and the desired behavior should be accessible via the Pause key and its Ctrl+S alias. Closing 😊

@carlos-zamora carlos-zamora closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

4 participants