Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a helper function either in terminal or the textbuffer that allows easy movement of text from 1 location to another #2163

Open
PankajBhojwani opened this issue Jul 30, 2019 · 1 comment
Open

Implement a helper function either in terminal or the textbuffer that allows easy movement of text from 1 location to another #2163

PankajBhojwani opened this issue Jul 30, 2019 · 1 comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Icebox ❄

Comments

@PankajBhojwani
Copy link
Contributor

DeleteCharacter and InsertCharacter both require moving text while retaining their text attributes. The logic used to do that movement should be put into a separate helper function so that other operations can make use of it as well.

Originally posted by @PankajBhojwani in https://github.com/_render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMTg5NzIxMjU3OnYy/pull_request_review_threads/discussion
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 30, 2019
@PankajBhojwani PankajBhojwani added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jul 30, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 30, 2019
@miniksa miniksa removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 1, 2019
@miniksa
Copy link
Member

miniksa commented Aug 1, 2019

Yep. Pankaj and I talked about this. It just needs doing.

@zadjii-msft zadjii-msft added this to the Console Backlog milestone Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Icebox ❄
Development

No branches or pull requests
3 participants
@miniksa @zadjii-msft @PankajBhojwani