Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: ConHost Caption BoundingRects dissapeared #2176

Open
carlos-zamora opened this issue Jul 31, 2019 · 3 comments
Open

Bug Report: ConHost Caption BoundingRects dissapeared #2176

carlos-zamora opened this issue Jul 31, 2019 · 3 comments
Labels
Area-Accessibility Issues related to accessibility Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Conhost For issues in the Console codebase
Milestone
Backlog

Comments

@carlos-zamora
Copy link
Member

Environment

Caused by Accessibility PR: 96496d8

Steps to reproduce

  1. open ConHost
  2. open inspect.exe
  3. find caption buttons

Expected behavior

bounding rects should appear over caption buttons

Actual behavior

bounding rects aren't there. But it seems like you can interact with them perfectly fine otherwise.

Other notes

I think the main culprit here is WindowUiaProvider. Not entirely sure what caused it though.
@carlos-zamora carlos-zamora added Product-Conhost For issues in the Console codebase Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility labels Jul 31, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 31, 2019
@carlos-zamora carlos-zamora added Help Wanted We encourage anyone to jump in on these. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 31, 2019
@carlos-zamora carlos-zamora added this to the August Releases milestone Jul 31, 2019
@zadjii-msft zadjii-msft modified the milestones: Windows vNext, 22H1 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H1, Terminal v1.14 Feb 2, 2022
@zadjii-msft zadjii-msft self-assigned this Mar 8, 2022
@zadjii-msft
Copy link
Member

Okay so presumably, this broke in 96496d8, in #1691.

Then, we reverted nearly all that in #6417

ironically, the Terminal's version of this still works fine

@zadjii-msft
Copy link
Member

after lunch: Look into WindowUiaProvider::get_HostRawElementProvider. That's my only lead.

@zadjii-msft
Copy link
Member

Okay I found nothing here. What I did find was:

  • this works fine for conhostv1
  • this DOESN'T work for conhostv2
  • this DOESN'T work for explorer
  • this DOESN'T work for the rejuv'd notepad
  • this works fine for terminal's titlebar when not showing the tabs in the title bar.

Given that this works generally poorly across the OS, I'm gonna punt this. If this did work, that's cool, sorry we broke it. I don't have the UIA expertise needed to figure out how this regressed.

@zadjii-msft zadjii-msft removed their assignment Mar 8, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.14, Backlog Mar 8, 2022
@zadjii-msft zadjii-msft added the Priority-2 A description (P2) label Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@carlos-zamora @DHowett-MSFT @zadjii-msft