Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offsetX/offsetY settings, respecting backgroundImageAlignment to determine which sides of the image to apply the offset to. #2620

Open
Tracked by #9995
michelforget opened this issue Aug 30, 2019 · 2 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone

Comments

@michelforget
Copy link

In a recent blog, your team indicated you could position a background image to your liking. Currently it appears on the very edge of the display (no gap). It would be nice to be able to specify an offsetX/offsetY setting, respecting backgroundImageAlignment to determine which sides of the image to apply the offset to, so that you could indent the image. The idea is that most people will use this to position a large-size icon somewhere in the window to make it super-obvious at a glance which shell is being displayed. Currently to get a gap you need to manually insert a gap around your image, and getting the transparency right isn't necessarily easy.

Proposed technical implementation details (optional)

@michelforget michelforget added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 30, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 30, 2019
@carlos-zamora carlos-zamora added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements labels Aug 30, 2019
@zadjii-msft
Copy link
Member

This is pretty closely related to #2370. IMO we should just do both all at the same time.

@DHowett-MSFT DHowett-MSFT added Help Wanted We encourage anyone to jump in on these. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 5, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Sep 5, 2019
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@zadjii-msft
Copy link
Member

From @Dominik-H in #12771

I propose adding an option to set padding for background image in settings. While "backgroundImageAlignment" is awesome and works fine for basic image placement adding an option for user to pad their image by requested amount of pixels would allow the user to place the image in any spot in the terminal window.

I am NOT proposing removal of backgroundImageAlignment but an extension option to add padding to image position.

Proposed technical implementation details (optional)

Of course this is up to the implementation team but my proposal is to add parameter similar to the "padding" that positions the text in the terminal.

  • Name of the parameter could be "backgroundImagePadding"
  • It would accept similar options as mentioned "padding" parameter: "#", "#, #" and "#, #, #, #"
  • Default value would be "0, 0, 0, 0"
  • When both "backgroundImageAlignment" parameter and new "backgroundImagePadding" are set, the Alignment position would be taken as origin and added to the padding values which would yield new position of the image e.g.: "bottomRight" option is bottom right corner and together with padding of "0, 10, 0, 10" it would calculate position offseting the image by 10 pixels from bottom right corner in both directions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants