Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: link generation for files + other data types #2671

Open
Tracked by #5001
AshrafMichail opened this issue Sep 5, 2019 · 2 comments
Open
Tracked by #5001

Feature Request: link generation for files + other data types #2671

AshrafMichail opened this issue Sep 5, 2019 · 2 comments
Labels
Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone

Comments

@AshrafMichail
Copy link

AshrafMichail commented Sep 5, 2019

#2094 Description of the new feature/enhancement

There are a number of scenarios where having a link detected with a meaningful click action would be helpful:

  1. File (optional line number): click action could launch an editor.

  2. Directory: click action can to change to that directory

  3. Git commit: click action can bring up a description of the commit in the appropriate web page or tool

@AshrafMichail AshrafMichail added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 5, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 5, 2019
@AshrafMichail AshrafMichail changed the title Feature Request: link detection for files + other items Feature Request: link generation for files + other data types Sep 5, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Sep 5, 2019
@DHowett-MSFT DHowett-MSFT added Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Product-Terminal The new Windows Terminal. labels Sep 5, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 5, 2019
@DHowett-MSFT DHowett-MSFT added Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 5, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 5, 2019
@DHowett-MSFT
Copy link
Contributor

Linking #574, since the infrastructure for detecting URLs/regex-matching files will be the same.

@zadjii-msft
Copy link
Member

Originally posted by @skyline75489 in #9669:

Inspired by #8166 (comment), we can also make the result of ls clickable if the CWD is provided. This is also possible in iTerm2. I'm not sure which sequence or technology it uses to detect the CWD, though. Anyway, with OSC9;9 recently added, this is also possible in WT.

Originally posted by @skyline75489 in #7526 (comment)

I think this is what I prefer over #9661. And there is precedent like iTerm2 who handles the file URL detection very well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants