Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally persist font size changes when changed with CTRL+Mousewheel #2899

Open
naikrovek opened this issue Sep 25, 2019 · 2 comments
Open

Optionally persist font size changes when changed with CTRL+Mousewheel #2899

naikrovek opened this issue Sep 25, 2019 · 2 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
Specification Tracker
Milestone
Backlog

Comments

@naikrovek
Copy link

CTRL+MouseWheel font size changes should optionally persist to profiles.json

I move between monitors a lot and this means I change monitor geometries, resolutions, and pixel pitches frequently. Frequently enough that I need to change the font size in Terminal almost daily, and it would be lovely if my font size changes "stick" for the day. The multiple round trips required to change the font size to get it exactly where I want it via profiles.json is a bit tedious. So, for some, and for me definitely, changes to font size should persist when I use CTRL+MouseWheel.

I know this goes against the folks who want this to never persist, so perhaps a new keyboard shortcut is in order, or perhaps the behavior of CTRL+MouseWheel should be exposed in the keybindings section of profiles.json as a command. An additional command could be created (which persists the font size when you zoom) and could then be chosen by those who want this behavior.

Persisting the font size when it is changed with CTRL+MouseWheel is the behavior in Sublime Text and I've gotten quite used to this over time, and now I miss it (I especially miss it in VScode, but that's another issue.)

Thank you.
@naikrovek naikrovek added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 25, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 25, 2019
@naikrovek naikrovek changed the title Feature Request Optionally persist font size changes when changed with CTRL+Mousewheel Sep 25, 2019
@zadjii-msft
Copy link
Member

So, writing the profiles.json file is tricky business that we're happy to not be doing anymore. Not saying that this isn't possible now, but we'd want to be especially careful, or maybe think of a solution that doesn't involve changing that file.

This sounds to me like a subset of a pair of issues from before:

Though this one seems to have it's own particular path cut out. I'll leave it to the team to decide if it's a dupe or not.

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Sep 25, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 25, 2019
@zadjii-msft zadjii-msft removed the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 25, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Sep 25, 2019
@naikrovek
Copy link
Author

Is there not a settings dialog planned? How will it store settings? Or is it going to use some non-JSON settings store?

To be clear, I am fine if JSON is not involved; I do not care how this is implemented.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 26, 2019
@DHowett-MSFT DHowett-MSFT added this to Spec Needed ❓ in Specification Tracker via automation Sep 26, 2019
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
Specification Tracker
  
Spec Needed ❓
Milestone
Backlog
Development

No branches or pull requests
3 participants
@naikrovek @DHowett-MSFT @zadjii-msft