Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings menu doesn't open anything #4486

Closed
correcthorsebatterystaple opened this issue Feb 6, 2020 · 2 comments
Closed

Settings menu doesn't open anything #4486

correcthorsebatterystaple opened this issue Feb 6, 2020 · 2 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Question For questions or discussion Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered

Comments

@correcthorsebatterystaple

Environment

Windows build number: Microsoft Windows NT 10.0.18363.0

Steps to reproduce

  1. Install Windows Terminal (Preview) from Microsoft store
  2. Open Terminal
  3. Click the down caret on the top bar
  4. Click on settings

Expected behavior

A settings menu pops up

Actual behavior

The cursor goes into loading for a while and then returns to normal with no menu or GUI opening or anything else to change the settings.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 6, 2020
@j4james
Copy link
Collaborator

j4james commented Feb 6, 2020

There isn't a UI for the settings yet - that's issue #1564. However, the settings menu should open the profiles.json file (which contains the settings) in whatever editor you have associated with json files. If it's not doing anything, you'll probably need to reset that file type in your Windows settings.

@zadjii-msft
Copy link
Member

For the record, when you don't have a .json editor set by default, the system is doing something. It's trying to figure out what your .json editor is. Once it eventually determines that there isn't one, it'll pop this dialog
image

The real problem here is that there's a pretty substantial delay between clicking the settings button and that dialog opening. I'm not sure how much we can really do about this. The easy workaround is just to make sure to set some application as the default editor for .json files, until #1564 lands.

This is also some combination of #1422 #1586 #2599 #2895 #2036 #1928 #1786 #1704 #1460 #1664 #3592 #3244 #3240 #2969

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered labels Feb 7, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Question For questions or discussion Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

3 participants