Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wt.exe] Help windows are inconsistent #4612

Closed
alexandair opened this issue Feb 16, 2020 · 7 comments
Closed

[wt.exe] Help windows are inconsistent #4612

alexandair opened this issue Feb 16, 2020 · 7 comments
Labels
Area-Commandline wt.exe's commandline arguments Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone

Comments

@alexandair
Copy link

Environment

Microsoft Windows [Version 10.0.18363.535]

Steps to reproduce

# at the moment, this is considered a wrong syntax, so a help window pops up
# and help messages are not the same
PS C:\> wt `; split-pane -h cmd.exe
PS C:\> wt `; split-pane -v cmd.exe

# calling help gives us the third kind of a help message
--help, -h, -?, and /?

Expected behavior

All help windows are the same.

Actual behavior

Help windows contain different help messages dependent of the way how help is triggered.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 16, 2020
@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented Feb 16, 2020

For at least the first and second, you’re seeing “split pane with an unknown argument,” “split pane help” (-h is help, so it can’t be repurposed for -H), and the third is “wt global help”.

This seems consistent to me; any ideas how we can be better here?

@DHowett-MSFT DHowett-MSFT added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 16, 2020
@alexandair
Copy link
Author

wt ; split-pane -v cmd.exe
v

wt ; split-pane -h cmd.exe
h

The first command gives us an error, the second the help for split-pane sub-command, althought both dialog windows are a result of case-sensitivity issue with -H and -V.

Solution is quite simple. Remove -h as a shortcut for help command (--help, -?, and /? are more than enough).
Make horizontal and vertical arguments case-insensitive.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 17, 2020
@WSLUser
Copy link
Contributor

WSLUser commented Feb 18, 2020

Make horizontal and vertical arguments case-insensitive.

That would break compatibility with WSL so that can't happen. We should be able to use the wt commandline from any shell, including ones utilized in WSL (bash, fish, zsh, etc.)

@alexandair
Copy link
Author

@WSLUser
What do you mean "that would break compatibility"? wt.exe is still not GA. It's 0.9. So, now is the right time to fix the problem in PowerShell shell. Pre-GA time is the time for a breaking change. In any supported shell.

@WSLUser
Copy link
Contributor

WSLUser commented Feb 18, 2020

Yes there are a number of issues with the WT commmandline but certain fundamentals need to be kept in place. Perhaps we can simply add different aliases depending on the shell being supported. For PS (Windows installed) and cmd, we can get the traditional type of commandline and for everything else, continue the same syntax and simply fix the logic that appears that have a number of bugs with it.

@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Feb 18, 2020
@DHowett-MSFT DHowett-MSFT added Area-Commandline wt.exe's commandline arguments and removed Product-Terminal The new Windows Terminal. labels Feb 18, 2020
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Feb 19, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.x milestone Feb 21, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 21, 2020
@DHowett-MSFT
Copy link
Contributor

I'm closing this one as by-design for now. We're tracking the case sensitivity in another issue, and requests for the help dialog to change go in the discussion thread #4601.

The dialogs are consistent if you consider that one is an error for an invalid param, one is subcommand --help and one is wt --help. We could likely improve them by showing subcommand --help when we present an error for an invalid param.

/dup #4601

@ghost
Copy link

ghost commented Feb 21, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Feb 21, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Tag-Fix Doesn't match tag requirements Needs-Attention The core contributors need to come back around and look at this ASAP. labels Feb 21, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Commandline wt.exe's commandline arguments Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants