Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect vertical snapping with showTabsInTitlebar = false #4827

Closed
1kjo opened this issue Mar 6, 2020 · 4 comments
Closed

Incorrect vertical snapping with showTabsInTitlebar = false #4827

1kjo opened this issue Mar 6, 2020 · 4 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@1kjo
Copy link
Contributor

1kjo commented Mar 6, 2020

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable): master (3953b71d)

Any other software? no

Steps to reproduce

Set showTabsInTitlebar = false in config and try to resize the window.

test

Expected behavior

Window height correctly "snaps" to terminal lines.

Actual behavior

Window height doesn't "snap" exactly to terminal lines.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 6, 2020
@1kjo 1kjo mentioned this issue Mar 6, 2020
Merged
3 tasks
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Mar 6, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 6, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Mar 6, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 13, 2020
@DHowett-MSFT
Copy link
Contributor

I'd love to fix this, but I don't have engineering resources before version 1.0. 😄 Triaged, backlog.

@DHowett-MSFT
Copy link
Contributor

Help-wanted, though, too-- if somebody wanted, we would 100% take this in for 1.0

@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@marcelwgn
Copy link
Contributor

I think this was fixed at some point, I'm unable to reproduce this issue. The last line always stays where it should and the behavior is same between showTabsInTitlebar = false and showTabsInTitlebar = true

@lhecker
Copy link
Member

lhecker commented Apr 17, 2024

I'll close the issue for now then. We'll see if it comes back. Thanks!

@lhecker lhecker closed this as completed Apr 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@lhecker @DHowett-MSFT @marcelwgn @zadjii-msft @1kjo