Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y_Windows Terminal_Settings_Non text Contrast: For "Plus(+)" and "Drop down" buttons the non text contrast ratio is not meeting 3:1 ratio #5392

Closed
SpandanaPaladi opened this issue Apr 17, 2020 · 5 comments
Closed

A11y_Windows Terminal_Settings_Non text Contrast: For "Plus(+)" and "Drop down" buttons the non text contrast ratio is not meeting 3:1 ratio #5392

SpandanaPaladi opened this issue Apr 17, 2020 · 5 comments
Labels
Area-Accessibility Issues related to accessibility Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.
Milestone
Terminal Backlog

Comments

@SpandanaPaladi
Copy link

SpandanaPaladi commented Apr 17, 2020 •
edited
Loading

#A11y_WindowsTerminal; #WindowsTerminal; #A11yWCAG2.1; #A11yTCS; #DesktopApp; #Win10 ; #C+E-H; #NonTextContrast; #A11ySev2; #BenchMark; #MAS1.4.11

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier

Environment Details:
Version: 0.10.781.0

Repro steps:

  1. Hit the URL ""aka.ms/terminal"" and install ""Windows terminal (Preview)"" application
  2. Open ""Windows terminal (Preview)"" application
  3. Open the "Accessibility insights" tool to check color contrast ratio
  4. Tab to ""Windows Powershell"" tab
  5. Tab till "plus(+)" button and "Drop down" button
  6. Verify whether the color contrast ratio for "Plus(+)" and "drop down" buttons are meeting 3:1 contrast ratio using the "Accessibility insights" tool

Actual Result:​
Both the "Plus(+) and "Drop down" buttons are not meeting the non text contrast ratio 3:1 ratio
​
Expected Result:​
Both the "Plus(+) and "Drop down" buttons should meet the non text contrast ratio 3:1 ratio
​
User Impact:​
Low vision users will face difficulty if the buttons don't meet the non text contrast ratio 3:1
MAS Reference:​
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/Doc.aspx?sourcedoc=%7B6CA3BF14-2635-434A-832C-28DD9A18B9FC%7D&file=MAS%201.4.11%20%E2%80%93%20Non-text%20Contrast.docx&action=default&mobileredirect=true&cid=ab731ae2-c015-4cce-8636-dda5170eef34

Bug_plus button non text contrast
Bug_drop down non text contrast
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 17, 2020
@zadjii-msft zadjii-msft added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. Area-User Interface Issues pertaining to the user interface of the Console or Terminal labels Apr 17, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 20, 2020
@SpandanaPaladi SpandanaPaladi changed the title A11y_Windows Terminal_Open any application_Non text Contrast: For "Plus(+)" and "Drop down" buttons the non text contrast ratio is not meeting 3:1 ratio A11y_Windows Terminal_Settings_Non text Contrast: For "Plus(+)" and "Drop down" buttons the non text contrast ratio is not meeting 3:1 ratio Apr 21, 2020
@carlos-zamora
Copy link
Member

We just use the built-in resources from the WinUI Theme Dictionary. Submitted the following issue on the WinUI repo:
microsoft/microsoft-ui-xaml#2353

@carlos-zamora carlos-zamora mentioned this issue Apr 29, 2020
Closed
@Amulya-95
Copy link

Regressed in latest environment, still able issue is not fixed. We will take action and close the bug, once the issue gets resolved.

Attachments:

Bug 5392_Dropdown_Non text contrast

Bug 5392_Non text contrast issue

@carlos-zamora
Copy link
Member

@Amulya-95 as I said above, we're just using WinUI's resources here. Can we close this in favor of the attached WinUI issue?

CC @DHowett-MSFT

@Amulya-95
Copy link

Amulya-95 commented Jun 5, 2020 •
edited
Loading

#1901 still in Active (open) state.

As per C&AI External bug process we will take action on this bug once the external bug is fixed and verified

@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) labels Dec 3, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 3, 2020
@zadjii-msft zadjii-msft added the Tracking-External This bug isn't resolved, but it's following an external workitem. label Dec 3, 2020
@zadjii-msft
Copy link
Member

image
image

(it can't auto-detect the colors for the split button, so I picked them manually)

I believe this was fixed at some point in the past, likely when we updated a MUX version (unclear which).

I also think we've got a new a11y team now so I'm gonna close this one out.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.
Projects
None yet
Milestone
Terminal Backlog
Development

No branches or pull requests
6 participants
@carlos-zamora @DHowett-MSFT @zadjii-msft @cinnamon-msft @Amulya-95 @SpandanaPaladi