Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COOKED_READ] Ctrl+Backspace does nothing if the input length limit has been reached #8008

Closed
SecondFlight opened this issue Oct 22, 2020 · 7 comments · Fixed by #15783
Closed

[COOKED_READ] Ctrl+Backspace does nothing if the input length limit has been reached #8008

SecondFlight opened this issue Oct 22, 2020 · 7 comments · Fixed by #15783
Labels
Area-CookedRead The cmd.exe COOKED_READ handling Area-Input Related to input processing (key presses, mouse, etc.) In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Conhost For issues in the Console codebase
Milestone
Backlog

Comments

@SecondFlight
Copy link

SecondFlight commented Oct 22, 2020 •
edited

Environment

Windows build number: 10.0.18363.1139
Windows Terminal version: 1.3.2651.0

Steps to reproduce

  1. Open a new terminal tab
  2. Type or paste text into the prompt until the length limit is reached.
  3. Press Ctrl+Backspace.

Expected behavior

Some text is removed.

Actual behavior

No text is removed:

2020-10-22_12-00-30
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 22, 2020
@zadjii-msft
Copy link
Member

What shell are you using? cmd, powershell, pwsh (powershell core), some WSL shell like bash, zsh, fish...?

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 22, 2020
@SecondFlight
Copy link
Author

Sorry! I'm using my default, which is cmd.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Oct 22, 2020
@ghost

This comment has been minimized.

Sign in to view
@ghost

This comment has been minimized.

Sign in to view
@SecondFlight
Copy link
Author

Hi @alannt777, thanks for investigating. Is your length limit set artificially low? The input size limit needs to be reached for this bug to be reproduced; see step 2.

Here's how it looks on my setup:

2020-10-22_12-00-30

@ghost
Copy link

ghost commented Oct 22, 2020

Oops. I should have read the description properly. But I don't think anyone would use a command (and its arguments) that would be this long.

@DHowett
Copy link
Member

DHowett commented Oct 23, 2020

Interesting. CMD's line editor is actually part of the console host, so this issue is valid here. Thanks!

@DHowett DHowett changed the title Ctrl+Backspace does nothing if the input length limit has been reached [COOKED_READ] Ctrl+Backspace does nothing if the input length limit has been reached Oct 23, 2020
@DHowett DHowett added Area-Input Related to input processing (key presses, mouse, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Oct 23, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 23, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 23, 2020
@DHowett DHowett added this to the Console Backlog milestone Oct 23, 2020
@zadjii-msft zadjii-msft modified the milestones: Console Backlog, Backlog Jan 4, 2022
@zadjii-msft zadjii-msft added the Area-CookedRead The cmd.exe COOKED_READ handling label Feb 23, 2022
@lhecker lhecker mentioned this issue Aug 1, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Aug 2, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CookedRead The cmd.exe COOKED_READ handling Area-Input Related to input processing (key presses, mouse, etc.) In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Rewrite COOKED_READ_DATA microsoft/terminal
3 participants
@DHowett @SecondFlight @zadjii-msft