Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to configure display of auto detected links, normally and on hover #8294

Open
PankajBhojwani opened this issue Nov 16, 2020 · 5 comments
Labels
Area-Schema Things that have to do with the json schema. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone

Comments

@PankajBhojwani
Copy link
Contributor

PankajBhojwani commented Nov 16, 2020

Description of the new feature/enhancement

Allow the user to define how detected patterns should be displayed, when hovered and not.

See (see #7691 (comment)) and this

Wanted to make this an official issue where we can discuss the extent to which this should be implemented (should it just be limited to font style? or also font face? and what about font size? or other effects too)

@PankajBhojwani PankajBhojwani added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 16, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 16, 2020
@zadjii-msft
Copy link
Member

So, mixing and matching multiple fonts in the same TermControl might be Hard, so let's leave different font faces out of the question for now. I think different attributes seems reasonable, but how do we express that in the JSON?

@zadjii-msft zadjii-msft added Area-Schema Things that have to do with the json schema. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. labels Nov 16, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 16, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Nov 16, 2020
@PankajBhojwani PankajBhojwani removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 17, 2020
@PankajBhojwani
Copy link
Contributor Author

I think different attributes seems reasonable, but how do we express that in the JSON?

How does a map of key-value pairs sound? Allowed keys are foreground, background and any of the ExtendedAttributes values

@zadjii-msft
Copy link
Member

wait so then it's

"foreground": "red", // a 16-color table value
"background": "#0044ff", // an RGB value
"underlined": true // ?

@DHowett
Copy link
Member

DHowett commented Nov 17, 2020

We need to comport this with the configuration flags for specifying different fonts, suggested in ... some workitem that exists on this repo. I don't want to do this without doing that, and they should definitely look roughly the same in terms of user-facing options.

@DHowett
Copy link
Member

DHowett commented Nov 17, 2020

That would be #1790.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Schema Things that have to do with the json schema. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants