-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render tig
correctly
#909
Comments
Is this WSL tig, Cygwin tig, tig over ssh, or some other tig build? I can't reproduce it with WSL tig, which leads me to believe that (if it's Cygwin tig) it might be trying to do something irresponsible because the runtime's knowledge of Consoles stopped evolving back before I was born. 😁 |
So, this is tig in the command prompt:
|
This looks like an upstream bug with git/cygwin/msys2/msys/whatever it is today. @bitcrazed will take on moving this upstream. |
@johannesherr That feels to me like mixed up tabstops, which I believe we fixed for 10.0.18362. |
@DHowett-MSFT Ok, thanks for the info. Then I will wait and hope to get the update soon. :) Until then it's unfortunately back to Cygwin for me. |
@bitcrazed Is there an upstream issue on msys/cygwin/whatever that's tracking this currently? |
|
Not that I know of. Will work with @cinnamon-msft to get this tracked. @johannesherr & @decriptor - do you have any repro text that we can test and verify against? |
I'm having a slightly different render issue than previous comments. The timeline lines render correctly put pressing "Enter" over a commit to bring up the message/diff gets glitchy with the divider. Also, resizing is completely broken. I'm using Git Bash with Git for Windows 2.25.0.
|
@ToadKing Thanks for the info - what version of Terminal are you using? FWIW, the team are cranking through bugs as we speak. Running Terminal v.0.9.433.0, I tried tig v2.3.0 on the Terminal repo in an Ubuntu/WSL2 session. Things look a little better (esp. re. disc symbol rendering size): Resizing also seems to be somewhat improved: 🙏 If anyone would like to add rendering glitches to this thread, please mark/circle/highlight specific issues and describe what you'd expect to see ... its sometimes a little tricky to pick out issues from a brief description. Thanks |
I'm using Terminal 0.9.433.0. Running tig from WSL works fine, it looks like the issues I'm running into are specifically with Git for Bash/Cygwin builds of tig. Also, it seems the corruption mainly happens when the log/diff appears in a horizontal panel like in my screenshot, not a vertical one in yours. |
@UncleInf Can you share the commandline from your msys/gitbash/cygwin profile? If it just launches |
I get the same error in Git Bash installed with Git for Windows. {
"guid": "{118dc651-b866-4c21-8507-4962c09b9922}",
"name" : "Git Bash",
"commandline" : "C:/Program Files/Git/bin/bash.exe --cd-to-home",
"icon" : "C:/Program Files/Git/mingw64/share/git/git-for-windows.ico",
"startingDirectory" : "%HOMEDRIVE%%HOMEPATH%",
"fontSize": 11
} Adding |
Huh. To be entirely fair, this also doesn't work outside of Terminal ... This is likely due to Cygwin's VT emulation layer. I just tried it out with Cygwin >= 3.1, which gets rid of the VT emulation layer, and... switch it back to 3.0.7 (has the VT emulation layer), and ... We probably just need to wait for Git for Windows to upgrade to a runtime that is less old. |
Just an observation... I run Terminal v1.4.2652.0 and run Git for Windows 2.27.0 (I know it's not the latest version) and it uses 3.1.4. I use
|
I think most of the problem was fixed in Git for Windows release 2.27. Tig renders normally for me now, for the most part. I still get some spurious spacing in console output when tig shells out to commit. I also get an occasional hang when transitioning back to tig after committing. But it's much better! |
I can confirm tig renders correctly in Windows Terminal now as well. Git for Windows version 2.29.2.windows.1 |
Oh, well that's a pleasant surprise! I guess we can just close this one out then, thanks for the follow-ups all! |
It would be great if the program
tig
worked properly in Terminal.Here is a screenshot using
tig
on this repo:The text was updated successfully, but these errors were encountered: