Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pasting with 1.7.572.0 preview and fish causes strange behavior #9517

Closed
KotlinIsland opened this issue Mar 17, 2021 · 8 comments
Closed

pasting with 1.7.572.0 preview and fish causes strange behavior #9517

KotlinIsland opened this issue Mar 17, 2021 · 8 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-External For issues that are outside this codebase

Comments

@KotlinIsland
Copy link

KotlinIsland commented Mar 17, 2021

This doesn't happen in 1.6.10517.0 or when i switch to bash.

Environment

Windows build number: Win32NT             10.0.18363.0 Microsoft Windows NT 10.0.18363.0
Windows Terminal version (if applicable): 1.7.572.0

Any other software? Ubuntu-20.04, fish version 3.2.0

Steps to reproduce

paste a command into wt eg echo foo

Expected behavior

command is pasted as is

Actual behavior

foo^[[201~echo foo appears on the line and the foo^[[201~ part isn't able to be backspaced.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 17, 2021
@KotlinIsland KotlinIsland changed the title pasting with 1.7.572.0 preview and fish causes strange behaviour pasting with 1.7.572.0 preview and fish causes strange behavior Mar 17, 2021
@DHowett
Copy link
Member

DHowett commented Mar 17, 2021

It looks like fish is requesting bracketed paste mode, but cannot handle bracketed paste mode.

It has asked us to include \e[200~ and \e[201~ so it knows where your pasted content started and ended, and we have done as it asked.

@skyline75489
Copy link
Collaborator

I can't repro this locally with stock fish configuration. Is there any special configuration you're using that might relate to this?

@KotlinIsland
Copy link
Author

image
Colleague also experiencing the exact same behavior.

@skyline75489
Copy link
Collaborator

Yeah this is caused by #9034, which as @DHowett pointed out, is actually the correct thing to do. What's weird is that somehow fish does not handle the bracketed paste response correctly. So we need to know what's wrong on the fish side.

@skyline75489
Copy link
Collaborator

OK after upgrading fish to 3.2.0 I can repro this locally. This is indeed a shell issue. See fish-shell/fish-shell#7770 . This should be fixed in 3.2.1 according to that thread.

@skyline75489
Copy link
Collaborator

Meanwhile, you may choose to downgrade fish using:

sudo apt install fish=3.1.0-1.2 fish-common=3.1.0-1.2

This fixes the issue for me.

@DHowett
Copy link
Member

DHowett commented Mar 17, 2021

@skyline75489 thanks so much!

/dup fish-shell/fish-shell#7770

@ghost
Copy link

ghost commented Mar 17, 2021

Hi! We've identified this issue as a duplicate of one that exists on somebody else's Issue Tracker. Please make sure you subscribe to the referenced external issue for future updates. Thanks for your report!

@ghost ghost closed this as completed Mar 17, 2021
@ghost ghost added Resolution-External For issues that are outside this codebase and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 17, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-External For issues that are outside this codebase
Projects
None yet
Development

No branches or pull requests

3 participants