Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Open in Windows Terminal" of WT Preview disappears if WT is not installed #9857

Open
Henry-ZHR opened this issue Apr 16, 2021 · 10 comments
Open

"Open in Windows Terminal" of WT Preview disappears if WT is not installed #9857

Henry-ZHR opened this issue Apr 16, 2021 · 10 comments
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@Henry-ZHR
Copy link

Henry-ZHR commented Apr 16, 2021 •
edited

Windows Terminal version (or Windows build number)

Windows 10.0.21354.0

Windows Terminal Preview v1.8.1032.0

Other Software

No response

Steps to reproduce

Uninstall Windows Terminal

Expected Behavior

Only "Open in Windows Terminal" of WT disappears

Actual Behavior

"Open in Windows Terminal" of both WT and WT Preview disappear
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 16, 2021
@zadjii-msft
Copy link
Member

  • What versions of the Terminal did you have installed? 1.6...? 1.7...?
  • Have you rebooted since installing/uninstalling? explorer.exe is notoriously aggressive about caching context menu entries.

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 16, 2021
@Henry-ZHR
Copy link
Author

@zadjii-msft Rebooting doesn't help

Just install Windows Terminal can get them back, but I just want to see the one of WT Preview

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 16, 2021
@zadjii-msft
Copy link
Member

Again, which version of Windows Terminal Preview, release, do you have installed? We just changed how those dialogs are registered, but the Store isn't always the best at rolling out updates. This might be a weird interaction between the 1.8 preview and the 1.7 stable, but I'll need some version numbers to be sure

@zadjii-msft zadjii-msft added Area-ShellExtension For issues related to the explorer right-click context menu Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Apr 16, 2021
@Henry-ZHR
Copy link
Author

Windows Terminal Preview v1.8.1032.0

(I added them to the issue description just now

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 16, 2021
@Henry-ZHR
Copy link
Author

I think I had Windows Terminal v1.7.1033.0 installed but I'm not sure since I can't install it from Microsoft Store now

Windows Terminal Preview installed by msixbundle from GitHub Release

@seritools
Copy link

Can confirm - clean install of Insider build 21364, Terminal Preview 1.8.1032.0.

If the non-preview version is not installed, the context menu entry does not appear. If I install it, both regular and preview entries appear.

@vefatica
Copy link

I can repro this also. I have 1.7.1091.0 and 1.8.1092.0 both installed using bundles from GitHub. With this

image

uninstalling 1.7.1091 removes both context menu items. Reinstalling 1.7.1091 brings both back.

@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Apr 29, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 29, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Apr 29, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 29, 2021
@TBBle
Copy link

TBBle commented May 3, 2021

I hit this problem the other day, both versions installed from the store, same Preview version as the original bug report, but I didn't notice the non-preview version number before I uninstalled it. This is Windows 10 20H2 (19042.928).

After a reboot or two after uninstalling the non-Preview version (and the last reboot was a system-crash, so know it was a clean boot), I happened to notice that my "Open in Windows Terminal" option is back, just for the Preview version (the only one I have installed), so I assume this symptom can be triggered by Explorer caching stuff. In that session I was also removing "X here" registry keys for things like Git Bash or MSYS (since I want to run those in Terminal, not conhost) and it was taking effect immediately, but I assume things registered by CLSID rather than a 'shell' registry key are more likely to be cached until reboot.

Not that useful for @Henry-ZHR, but for anyone else who finds this ticket with the same symptoms, check again after next system startup.

@zadjii-msft zadjii-msft mentioned this issue May 3, 2021
Closed
@DHowett DHowett mentioned this issue Jul 22, 2021
Closed
@zadjii-msft zadjii-msft added the Priority-3 A description (P3) label Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft mentioned this issue Feb 13, 2023
Closed
@gbr000
Copy link

gbr000 commented Feb 13, 2023

What can we do until then? Please provide a .reg file or PowerShell command to fix that!

@vefatica
Copy link

vefatica commented Feb 13, 2023 •
edited

My home-brewed solution works. I have an unzip-only installation of WT. I use this this with similar entries in HKEY_CLASSES_ROOT\Directory\Background, HKEY_CLASSES_ROOT\Drive, and HKEY_CLASSES_ROOT\Folder. I reckon you'll have to (at least) use the path to your preferred shell, change the "*cdd" command to something appropriate, and duplicate this for the other three keys. If WT has a command line option for start-up directory, and you don't mind getting the default start-up shell and directory, you might be able to omit the shell and its command. I don't know if that will work; I haven't tried it.

An entry in "...\Background" lets you start WT from the right-click context menu for the background in an Explorer window and on the desktop itself (which is a directory background).

Windows Registry Editor Version 5.00

[HKEY_CLASSES_ROOT\Directory\shell\WT]
@="WTHere"

[HKEY_CLASSES_ROOT\Directory\shell\WT\command]
@="wt.exe nt d:\\tc28\\tcc.exe *cdd \"%V\""

I also have this, which makes life nice. Without this you might (above) have to supply a path to windowsterminal.exe.

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\wt.exe]
@="d:\\wt\\exe\\windowsterminal.exe"
"Path"=" d:\\wt\\exe"

@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@TBBle @seritools @zadjii-msft @Henry-ZHR @vefatica @gbr000