Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the _is_navigation special check in chaining #20

Closed
MarcCote opened this issue Aug 23, 2018 · 2 comments
Closed

Remove the _is_navigation special check in chaining #20

MarcCote opened this issue Aug 23, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@MarcCote
Copy link
Contributor

With the new and better chaining that supports nonlinear quests, there might not be a use for the special check self._is_navigation(nav_parent.action) when checking for action dependencies. That check was originally added to help generate more interesting (read longer chains) "linear" quest. Once PR #17 is merged, that type of quest could be still generated by decomposing it in multiple subquests.

For instance, take key > go north > unlock chest with key would be decomposed into the following subquests: (take key, go north, unlock chest with key) or maybe (take key, go north > unlock chest with key).

@kumaran-14
Copy link

Can i do this?

@MarcCote
Copy link
Contributor Author

Hi. Fixing this issue requires a good understanding of the forward/backward chaining algorithms. If you feel comfortable with those please give it a try. Make sure your PR has proper unit tests showing that the same kind of quests (i.e. long chain of actions extending to multiple rooms) can still be generated, though (i.e. probably with a quest breadth > 1).

@MarcCote MarcCote added the enhancement New feature or request label May 2, 2023
@MarcCote MarcCote added the wontfix This will not be worked on label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants