Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trainers tutorial: switch dataset #1074

Closed
adamjstewart opened this issue Jan 31, 2023 · 1 comment · Fixed by #1124
Closed

Trainers tutorial: switch dataset #1074

adamjstewart opened this issue Jan 31, 2023 · 1 comment · Fixed by #1124
Labels
datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation

Comments

@adamjstewart
Copy link
Collaborator

Summary

We should switch the dataset for our PyTorch Lightning Trainers tutorial.

Rationale

Our current dataset is downloaded from Radiant Earth, requiring additional dependencies and preventing users from running the tutorial without first signing up for an account and modifying the notebook. It would be better to use a dataset that does not require these things so that the tutorial works out of the box.

Implementation

Most of our other current tutorials use EuroSAT, so we could use that.

Alternatives

Should we just choose the smallest and fastest to download dataset and use that for all tutorials?

Additional information

No response

@adamjstewart adamjstewart added documentation Improvements or additions to documentation datasets Geospatial or benchmark datasets labels Jan 31, 2023
@adamjstewart
Copy link
Collaborator Author

Another benefit: secrets aren't shared with unprivileged actors, so our tutorials tests fail when anyone other than a maintainer opens a PR that modifies the notebooks. By switching to a public dataset, the tests will always work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant