-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests require internet access #194
Comments
+1 for this, having tests randomly fail is quite confusing -- I don't think we actually need to be testing weight downloads |
Our tests are starting to fail more often than not. Failures are usually from failed downloads. For trainers, the solution is to simply add a config option for whether or not to download pretrained models and set it to False (we shouldn't be downloading things by default anyway). For our resnet50 pretrained model we'll need to figure out something else. We could generate it and store it locally so that we can still test loading without having to rely on an internet connection. Anyone want to work on this? |
We can just have the trainers default to not use pretrained weights. Is this what you meant @adamjstewart? |
Correct |
In #185, @ashnair1 reported that our CI was failing because the trainer tests require internet access:
We should see if it's possible to monkeypatch things to skip downloads/pre-trained models for testing.
The text was updated successfully, but these errors were encountered: