Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline for dropping Python 3.6 support #413

Closed
weiji14 opened this issue Feb 18, 2022 · 3 comments · Fixed by #482
Closed

Timeline for dropping Python 3.6 support #413

weiji14 opened this issue Feb 18, 2022 · 3 comments · Fixed by #482
Milestone

Comments

@weiji14
Copy link
Contributor

weiji14 commented Feb 18, 2022

Continuing on from discussion in #326 and #409 (comment). Python 3.6 has reached end of life (EOL) as of 23 Dec 2021. This issue is to discuss and track when torchgeo should drop Python 3.6 support.

Is torchgeo still supporting Python 3.6?

For the time being, yes. I would prefer to stick to Python's EOL timeline, but there are many systems that still use Python 3.6. I strongly disagree with numpy's aggressive deprecation timeline, as Google Colab still runs Python 3.7 by default. I think we'll likely compromise and stick to whatever versions of Python that PyTorch supports (currently 3.6–3.9 in the latest release, soon to be 3.7–3.9 in the next release). Unless I can convince @calebrob6 to drop 3.6 support since PyTorch has already dropped it in master.

Originally posted by @adamjstewart in #409 (comment)

@adamjstewart
Copy link
Collaborator

PyTorch 1.11 should be coming pretty soon: pytorch/pytorch#72267

In general, we can always backport things like dataclasses and typing-extensions if we need to. There are rarely newer language features that we need that can't be backported.

@adamjstewart adamjstewart added this to the 0.3.0 milestone Feb 18, 2022
@calebrob6
Copy link
Member

I only have the slightest preference for not dropping 3.6 (it just seemed silly to do some extra work to make it slightly harder to use the library 😄). PyTorch 1.11 seems like a great reason to drop it.

@adamjstewart
Copy link
Collaborator

Based on https://pypistats.org/packages/torchgeo very few of our users are using Python 3.6.

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2022
@adamjstewart adamjstewart converted this issue into discussion #593 Jun 18, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants