Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster notebook testing #665

Closed
adamjstewart opened this issue Jul 10, 2022 · 1 comment · Fixed by #1124
Closed

Faster notebook testing #665

adamjstewart opened this issue Jul 10, 2022 · 1 comment · Fixed by #1124
Labels
documentation Improvements or additions to documentation testing Continuous integration testing
Milestone

Comments

@adamjstewart
Copy link
Collaborator

Summary

We should make our tutorial notebook tests faster.

Rationale

Our tutorial notebooks currently take 40+ minutes to test. We hope to greatly expand the number of tutorials in TorchGeo in the future, so we should find ways to improve testing time. Some of these improvements may even translate to other tests as well. If we can get our tutorial notebook tests < 10 min, we could consider testing them on all PRs, Python versions, and platforms.

Implementation

I've had several ideas for how to improve this:

  • Cache download files using cache action
  • Run tests in parallel using pytest-xdist
  • Use hidden cells or env vars to shorten number of epochs in nbmake

Alternatives

If anyone can think of any other options, let me know!

Additional information

No response

@adamjstewart adamjstewart added documentation Improvements or additions to documentation testing Continuous integration testing labels Jul 11, 2022
@adamjstewart
Copy link
Collaborator Author

Also found nbval, possibly another option to nbmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant