Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various rounding bugs #679

Closed
adamjstewart opened this issue Jul 18, 2022 · 2 comments · Fixed by #736
Closed

Various rounding bugs #679

adamjstewart opened this issue Jul 18, 2022 · 2 comments · Fixed by #736
Assignees
@adamjstewart
Milestone
0.3.1

Comments

@adamjstewart
Copy link
Collaborator

See #674 and #675.

I identified several other places where this bug may still occur: #675 (comment)

We should investigate and fix these.
@adamjstewart
Copy link
Collaborator Author

Users at IBM Research reported a similar bug with RasterDataset.

@adamjstewart adamjstewart added this to the 0.3.1 milestone Aug 16, 2022
@adamjstewart adamjstewart self-assigned this Aug 21, 2022
@adamjstewart
Copy link
Collaborator Author

// is also floor division, we should use / and round the result.

This was referenced Aug 22, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamjstewart adamjstewart

Labels
None yet
Projects
None yet
Milestone
0.3.1
Development

Successfully merging a pull request may close this issue.

Fix float rounding issues microsoft/torchgeo
1 participant
@adamjstewart