Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset/DataModule consistency #815

Closed
adamjstewart opened this issue Oct 4, 2022 · 0 comments · Fixed by #846
Closed

Dataset/DataModule consistency #815

adamjstewart opened this issue Oct 4, 2022 · 0 comments · Fixed by #846
Labels
backwards-incompatible Changes that are not backwards compatible
Milestone
0.4.0

Comments

@adamjstewart
Copy link
Collaborator

Summary

We should ensure that all Dataset and DataModule file and class names match.

Rationale

The user should not have to guess what the DataModule name is, it should be easy to determine based on the Dataset name. Consistency is important.

Implementation

At the moment, we have datasets like TropicalCycloneWindEstimation and data modules like CycloneDataModule. We should pick one name and use it consistently. Not sure if there are other instances of this.

Alternatives

No response

Additional information

No response
@adamjstewart adamjstewart added the backwards-incompatible Changes that are not backwards compatible label Oct 4, 2022
@adamjstewart adamjstewart added this to the 0.4.0 milestone Oct 4, 2022
@nilsleh nilsleh mentioned this issue Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backwards-incompatible Changes that are not backwards compatible
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Datamodule naming TropicalCyclone nilsleh/torchgeo
1 participant
@adamjstewart