Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File handle leak drawing figures #825

Closed
austinmw opened this issue Oct 10, 2022 · 1 comment · Fixed by #826
Closed

File handle leak drawing figures #825

austinmw opened this issue Oct 10, 2022 · 1 comment · Fixed by #826
Labels
trainers PyTorch Lightning trainers
Milestone
0.4.0

Comments

@austinmw
Copy link

Description

I think there's a memory leak here:

[WARNING] /opt/conda/lib/python3.8/site-packages/torchgeo/datasets/nasa_marine_debris.py:246: RuntimeWarning: More than 20 figures have been opened. Figures created through the pyplot interface (matplotlib.pyplot.figure) are retained until explicitly closed and may consume too much memory. (To control this warning, see the rcParam figure.max_open_warning).

Steps to reproduce

Run NASAMarineDebrisDataModule for > 5 epochs

Version

latest
@austinmw austinmw changed the title Figures not closed Memory leak drawing figures Oct 10, 2022
@adamjstewart
Copy link
Collaborator

Technically this isn't a memory leak but a file handle leak. But yes, we can definitely fix this. Gimme a min.

@adamjstewart adamjstewart changed the title Memory leak drawing figures File handle leak drawing figures Oct 10, 2022
@adamjstewart adamjstewart added the trainers PyTorch Lightning trainers label Oct 10, 2022
@adamjstewart adamjstewart mentioned this issue Oct 10, 2022
Merged
@adamjstewart adamjstewart added this to the 0.3.2 milestone Oct 11, 2022
@adamjstewart adamjstewart modified the milestones: 0.3.2, 0.4.0 Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
trainers PyTorch Lightning trainers
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Trainers: fix plotting file handle leak microsoft/torchgeo
2 participants
@adamjstewart @austinmw