Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What use var in es2015? #89

Closed
Jungwoo-An opened this issue Oct 4, 2018 · 2 comments
Closed

What use var in es2015? #89

Jungwoo-An opened this issue Oct 4, 2018 · 2 comments
Labels
enhancement

Comments

@Jungwoo-An
Copy link
Contributor

I think should use const instead of var.

ntlm.ts
@damccorm
Copy link

damccorm commented Oct 4, 2018

Yeah, both _ and ntlm should probably be const. It won't break anything either way, but its good practice to have them as consts. Do you want to submit a pull request for this?

@Jungwoo-An
Copy link
Contributor Author

Yes. I do

@Jungwoo-An Jungwoo-An mentioned this issue Oct 5, 2018
Merged
@damccorm damccorm closed this as completed Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stephenmichaelf @Jungwoo-An @damccorm