Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTLM options need to all be specified #92

Closed
damccorm opened this issue Oct 8, 2018 · 2 comments
Closed

NTLM options need to all be specified #92

damccorm opened this issue Oct 8, 2018 · 2 comments

Comments

@damccorm
Copy link

damccorm commented Oct 8, 2018

Right now if ntlmHandler's workstation and domain aren't specified, calls to ntlm.createType1Message (and maybe other methods) fail. They work if workstation and domain are specified, even if they're set to empty strings.

Discovered this while investigating microsoft/azure-devops-node-api#172

FYI - this is where it fails because it tries to call toUppercase on an undefined object

@stephenmichaelf
Copy link
Member

Are you thinking this might be the reason people are having failures?

@damccorm
Copy link
Author

damccorm commented Oct 9, 2018

Potentially - I was having issues and changing this fixed it for me. I asked about it in the thread yesterday, we'll see what people say. Regardless, probably makes sense to release this patch and upgrade node-api's dependency because this definitely can cause errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants