Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Cannot GET /favicon.ico #339

Closed
mozgbrasil opened this issue Aug 5, 2021 · 2 comments
Closed

Cannot GET /favicon.ico #339

mozgbrasil opened this issue Aug 5, 2021 · 2 comments

Comments

@mozgbrasil
Copy link

Good morning my friends

I implemented this project in

https://acid-express-labs-ts.herokuapp.com/

But we see that the file "/favicon.ico" is not loaded

I even put a file in "src/public/favicon.ico"

But when building the project we see in "dist/public" the absence of this file

Thank you in advance if you can help

@mozgbrasil
Copy link
Author

mozgbrasil commented Aug 5, 2021

I add a file "favicon.ico" in a folder "src/public/"

I edited the "copyStaticAssets.ts" file and added

shell.cp("-R", "src/public/favicon.ico", "dist/public/favicon.ico");

and it worked

@peterblazejewicz
Copy link
Collaborator

just clarification. This project has no its own favicon.ico in the assets. One needs to adds it to the assets thx!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants