Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage.type used for both keywords and type references #44

Closed
aeschli opened this issue Jan 11, 2016 · 4 comments
Closed

storage.type used for both keywords and type references #44

aeschli opened this issue Jan 11, 2016 · 4 comments
Labels

Comments

@aeschli
Copy link

aeschli commented Jan 11, 2016

From @Franziskus1988 on December 23, 2015 10:58

interface TestInterface {
  testvar: string <- "string" colored;
  testfunc(): string <- "string" not colored;
}

Copied from original issue: microsoft/vscode#1612

@aeschli
Copy link
Author

aeschli commented Jan 11, 2016

@Franziskus1988 For what language is that?

@aeschli
Copy link
Author

aeschli commented Jan 11, 2016

I can reproduce in typescript

interface TestInterface {
  testvar: string;
  testfunc(): string;
}

image

The problem is that the interface and the first string both get the storage.type.ts scope.

@zhengbli zhengbli added the bug label Jan 20, 2016
@aeschli aeschli changed the title No coloring of function return value types in interfaces storage.type used for both keywords and type references Feb 4, 2016
@aeschli
Copy link
Author

aeschli commented Feb 4, 2016

Also function and var get the storage.type scope.
looking at http://tmtheme-editor.herokuapp.com/#!/editor/url/https://raw.githubusercontent.com/voronianski/oceanic-next-color-scheme/master/Oceanic%2520Next.tmTheme
it's probably correct to do so, and all type references should use entity.name.type.class

@zhengbli
Copy link
Contributor

zhengbli commented Mar 7, 2016

Closing as fixed by #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants