override keyword is duplicated in vscode autocomplete when accepting suggested override when the override keyword is already there

[DetachHead]

🔎 Search Terms

override vscode

🕗 Version & Regression Information

typescript 5.4.2
vscode 1.87.1

⏯ Playground Link

No response

💻 Code

class Foo {
    foo(a: number) {}
}

class Bar extends Foo {
    override fo//caret here
}

🙁 Actual behavior

class Foo {
    foo(a: number) {}
}

class Bar extends Foo {
    override override foo(a: number): void {
        
    }
}

🙂 Expected behavior

class Foo {
    foo(a: number) {}
}

class Bar extends Foo {
    override foo(a: number): void {
        
    }
}

Additional information about the issue

[jakebailey]

Try nightly, this was probably fixed by #57643

[DetachHead]

looks like it's mostly fixed, but it seems to briefly insert the duplicated override before removing it because the duplicated keyword appears when pressing ctrl+z after accepting the suggestion:

[jakebailey]

Yep:

The modifiers already present may be out of order, so we always add all the modifiers as part of the member completion entry, and send a code action to erase the present modifiers.