Add missing awaits when destructuring properties from a promisified type

[Andarist]

🔎 Search Terms

missing await destructuring codefix promise promisified members properties

🕗 Version & Regression Information

• This is the behavior in every version I tried

⏯ Playground Link

https://www.typescriptlang.org/play?#code/JYOwLgpgTgZghgYwgAgKoGdrIN4ChnLAAmAXMumFKAOYDc+yIcAthGRVSHbgL665EICADZwoKGAFcQCMMAD2IZNQhgM0ABQBKMgAUo85sEwAedVAB89XHHQBPGciky5i5JAracDBIoqMWFABeZVVzbQA6AHoAKgBGGKjrAl8Qf2xkWIAmROQeZBCVNUwobXoeIA

💻 Code

interface User {
  id: string;
  name: string;
}

declare function getUser(): Promise<User>;

async function test() {
  const name = getUser()./*1*/;

  const { /*2*/  } = getUser();
}

🙁 Actual behavior

with preferences.includeCompletionsWithInsertText at marker 1 we get completions for id and name and the line gets auto-fixed for us:

const name = (await getUser()).name

Nothing like that happens at marker 2 - no completions, no auto-fixes

🙂 Expected behavior

It would be cool if the second would work like the first one in this regard. It could go from:

  const { /*2*/  } = getUser();

to

  const { name } = await getUser();

Additional information about the issue

it's a feature request but the bug report template just worked the best here 😉

[fatcerberus]

I think the playground link is getting eaten... by some... linux or something

Just to be clear, the expected behavior is

const { name } = await getUser();

correct? I wasn't totally clear on whether you wanted the await on the RHS or on the properties themselves (since you said "missing awaits" plural). Although I guess you can't use await on the LHS of a destructuring...

[Andarist]

I think the playground link is getting eaten... by some... linux or something

Fixed, thanks for calling it out.

correct? I wasn't totally clear on whether you wanted the await on the RHS or on the properties themselves (since you said "missing awaits" plural). Although I guess you can't use await on the LHS of a destructuring...

Yes, correct. I've added this exact expected result in code form so it should be clear now.