Memory Leak disposing oldProgram

[cplepage]

🔎 Search Terms

memory leak

🕗 Version & Regression Information

• This is a crash

⏯ Playground Link

No response

💻 Code

// Your code here

🙁 Actual behavior

In safari (Webkit/JavaScriptCore). Old Program never gets GCed because of reference on it.

Memory build up really quickly.

🙂 Expected behavior

Unreferenced and gc

Additional information about the issue

No response

[cplepage]

Safari web inspector, running TS language service to getDiagnostics on file update.

without fix:

with fix:

[RyanCavanaugh]

Accepting PRs to fix memory leaks, but we obviously can't really investigate something without a repro

[cplepage]

@RyanCavanaugh definitely, I will build a little something to make this issue reproducible and figure out what could go on. But I will need some time. Please allow me 1-2 week and I will come back here with a clear workable playground.

[cplepage]

The easiest way to reproduce will be to run it as I encountered the issue.

Requirements

• Git
• Node >=18
• MacOS (issue is only in Safari)

Setting up

1. Clone the FullStacked Editor repo
2. Checkout the typescript branch
3. Pull all submodules
4. Build TypeScript
5. Install FullStacked Editor deps
6. Start with the MUI sample repo
7. Wait until the MUI sample project launches

Do all of this by copy/pasting the below snippet in Terminal.
Some of these steps will take quite a while.
Full process is up to 10 minutes.

git clone https://github.com/fullstackedorg/editor.git; cd editor
git checkout typescript
git submodule update --init --recursive --progress
cd lib/typescript; npm i; npm run build; cd ../..
npm i
npm start -- "https://github.com/fullstackedorg/editor-sample-mui.git?branch=ts"

*If at the end of the process you are not in Safari, close all popped up tabs and open http://localhost:9000 in Safari.

Testing the issue

In Safari, in FullStacked Editor, in the fullstackedorg/editor-sample-mui project,

1. Open any .ts/.tsx file and wait for the TypeScript icon (top-right) to stop flashing.
2. Open up the debug console, go in the Timelines tab and start recording.
3. Edit the opened .ts/.tsx file constantly (hit enter at an interval of 1-2s) and monitor the memory. It should stay around 500-700mb

Now with your favorite code editor, open and comment out lib/TypeScript/src/services/services.ts#1802. Then, in Terminal, stop and rerun npm start and redo the three steps above. Check the memory climb nonstop (will go beyond 1GB).