Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] merging modules across files #59

Closed
mhegazy opened this issue Jul 17, 2014 · 1 comment
Closed

[Design] merging modules across files #59

mhegazy opened this issue Jul 17, 2014 · 1 comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Jul 17, 2014

file1.ts:

module X.Y {
    export class Point {
        constructor(x: number, y: number) {
            this.x = x;
            this.y = y;
        }
        x: number;
        y: number;
    }
}

file2.ts:

module X.Y {
    export module Point {
        export var Origin = new Point(0, 0);
    }
}

Expected (old compiler):

Module 'Point' cannot merge with previous declaration of 'Point' in a different file 'class.ts'.

Actual (new compiler): no error

@mhegazy mhegazy added this to the TypeScript 1.1 milestone Jul 17, 2014
@mhegazy mhegazy assigned sophiajt and ahejlsberg and unassigned sophiajt and ahejlsberg Jul 17, 2014
@ahejlsberg
Copy link
Member

Fixed by #33.

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

4 participants