Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Errors] class implementing private type #66

Closed
mhegazy opened this issue Jul 17, 2014 · 2 comments · May be fixed by Woodpile37/TypeScript#10
Closed

[Errors] class implementing private type #66

mhegazy opened this issue Jul 17, 2014 · 2 comments · May be fixed by Woodpile37/TypeScript#10
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Jul 17, 2014

module m1 {
    export class C2 implements m3.i3 {
        public get p1() {
            return null;
        }

        public f55() {
            return "Hello world";
        }
    }
    module m3 {
        export interface i3 {
            f55(): string;
        }
    }
    class C1 { }
}

Expected: Exported class 'C2' implements private interface 'm3.i3'.

Actual: no error

@mhegazy mhegazy added this to the TypeScript 1.1 milestone Jul 17, 2014
@sophiajt
Copy link
Contributor

This should not be an error for normal codegen. There is no leakage of the knowledge that the class implements this interface outside of the module.

It should only be an error .d.ts (or we don't emit the private implements clause)

@sophiajt
Copy link
Contributor

Updated spec text.

@sophiajt sophiajt removed the Spec label Aug 18, 2014
@sophiajt sophiajt assigned mhegazy and unassigned sophiajt Aug 18, 2014
@mhegazy mhegazy closed this as completed Aug 19, 2014
@mhegazy mhegazy added the Fixed label Aug 19, 2014
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants