Add test plugin #3698

JoshLove-msft · 2024-06-28T19:00:15Z

Adds a test plugin demonstrating simple tracing and customization of list setters.
Fixes #3672

...Generator.CSharp.ClientModel.Plugin/src/Microsoft.Generator.CSharp.ClientModel.Plugin.csproj

...es/http-client-csharp/generator/Microsoft.Generator.CSharp.ClientModel.Plugin/src/Program.cs

...tor/Microsoft.Generator.CSharp.ClientModel/src/Microsoft.Generator.CSharp.ClientModel.csproj

...sharp/generator/Microsoft.Generator.CSharp.ClientModel/src/OutputTypes/ScmKnownParameters.cs

...nerator/Microsoft.Generator.CSharp.ClientModel/src/Providers/MrwSerializationTypeProvider.cs

...client-csharp/generator/Microsoft.Generator.CSharp.TestPlugin/src/Properties/AssemblyInfo.cs

...-client-csharp/generator/Microsoft.Generator.CSharp.TestPlugin/test/Mocks/MockTypeFactory.cs

...sharp/generator/Microsoft.Generator.CSharp/perf/Microsoft.Generator.CSharp.Tests.Perf.csproj

...s/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Properties/launchSettings.json

...ages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/MethodProvider.cs

…it-out-plugins

m-nash · 2024-06-29T00:40:13Z

packages/http-client-csharp/generator/Microsoft.Generator.CSharp.sln

@@ -28,16 +26,20 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Generator.CSharp.
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TestProjects.Local.Tests", "TestProjects\ProjFiles\TestProjects.Local.Tests.csproj", "{3AEDFB67-39E3-4BB7-976E-F44F59402034}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Generator.CSharp.ClientModel", "Microsoft.Generator.CSharp.ClientModel\src\Microsoft.Generator.CSharp.ClientModel.csproj", "{3712A9A0-EDC4-4CB8-81E4-EBF4993EF350}"
+EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "TestProjects.Plugin.Tests", "TestProjects\ProjFiles\TestProjects.Plugin.Tests.csproj", "{0E3D9973-FD30-4130-8652-26EF39B76D69}"


do we need this project still if we are collapsing plugins back together with their impl?

Yes, this is the generated project for the test plugin.

would this exist if you had this sample plugin in the final samples location which might be in a different repo?

Remove these from solns and get rid of proj refs.

packages/http-client-csharp/generator/TestPlugin/src/OutputTypes/TestPluginOutputLibrary.cs

packages/http-client-csharp/generator/TestPlugin/src/OutputTypes/TestPluginTypeFactory.cs

packages/http-client-csharp/generator/TestPlugin/src/TestPlugin.csproj

…it-out-plugins

azure-sdk · 2024-06-29T03:03:38Z

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp

azure-sdk · 2024-06-30T20:10:15Z

No changes needing a change description found.

m-nash · 2024-07-01T16:00:38Z

...sharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Providers/ClientMethodProvider.cs

+{
+    public class ClientMethodProvider : MethodProvider
+    {
+        public ClientMethodProvider(MethodSignatureBase signature, MethodBodyStatement bodyStatements, TypeProvider enclosingType, XmlDocProvider? xmlDocProvider = default) : base(signature, bodyStatements, enclosingType, xmlDocProvider)


I think we should settle on a convention for prefixing overrides by mgc.cm. I think Scm makes sense, but we should be consistent throughout the library.

...enerator/Microsoft.Generator.CSharp.ClientModel/src/Providers/ScmMethodProviderCollection.cs

m-nash · 2024-07-01T16:03:03Z

packages/http-client-csharp/generator/Microsoft.Generator.CSharp.sln

@@ -28,16 +26,20 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Generator.CSharp.
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TestProjects.Local.Tests", "TestProjects\ProjFiles\TestProjects.Local.Tests.csproj", "{3AEDFB67-39E3-4BB7-976E-F44F59402034}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Generator.CSharp.ClientModel", "Microsoft.Generator.CSharp.ClientModel\src\Microsoft.Generator.CSharp.ClientModel.csproj", "{3712A9A0-EDC4-4CB8-81E4-EBF4993EF350}"
+EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "TestProjects.Plugin.Tests", "TestProjects\ProjFiles\TestProjects.Plugin.Tests.csproj", "{0E3D9973-FD30-4130-8652-26EF39B76D69}"


would this exist if you had this sample plugin in the final samples location which might be in a different repo?

m-nash · 2024-07-01T16:03:36Z

packages/http-client-csharp/generator/Microsoft.Generator.CSharp.sln

+EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "TestProjects.Plugin.Tests", "TestProjects\ProjFiles\TestProjects.Plugin.Tests.csproj", "{0E3D9973-FD30-4130-8652-26EF39B76D69}"
+EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "SamplePlugin", "SamplePlugin\src\SamplePlugin.csproj", "{6825281D-C6BD-4E34-9F60-109D164EC928}"


same comment as above, I don't think this should be here given samples won't live here.

m-nash · 2024-07-01T16:06:19Z

...ages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/MethodProvider.cs

+        /// Converts an expression-based method provider to a method provider with <see cref="BodyStatements"/> populated. If the instance already has body statements, it is returned as is.
+        /// </summary>
+        /// <returns>An instance of a <see cref="MethodProvider"/> with <see cref="BodyStatements"/> populated.</returns>
+        public MethodProvider ToBodyStatementMethodProvider()


Feels like an internal helper not something we want as a public API.

...client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/MethodProviderCollection.cs

packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/StartUp/PluginHandler.cs

packages/http-client-csharp/generator/SamplePlugin/src/Program.cs

packages/http-client-csharp/generator/SamplePlugin/src/SamplePlugin.csproj

Found while working on #3698

JoshLove-msft added 4 commits June 28, 2024 11:53

Split out plugin into separate library

07b1ec1

fix ref

bdafd0e

Fix csproj

8cc402c

Remove dup tests

1184490

JoshLove-msft requested review from m-nash, bterlson, markcowl, allenjzhang and timotheeguerin as code owners June 28, 2024 19:00

Add test plugin csproj

bdce0f1

m-nash reviewed Jun 28, 2024

View reviewed changes

JoshLove-msft added 3 commits June 28, 2024 15:23

PR fb

b9cc749

Remove program.cs

001841e

npm-clean

b83aaf3

JoshLove-msft mentioned this pull request Jun 28, 2024

this casting is unfortunate, we should probably rethink how we want this to look #3701

Closed

JoshLove-msft added 2 commits June 28, 2024 15:29

extra space

740dfa5

collapse clientmodel

5643740

JoshLove-msft changed the title ~~Split out plugins~~ Add test plugin Jun 29, 2024

Merge branch 'main' of https://github.com/microsoft/typespec into spl…

92b3eb7

…it-out-plugins

m-nash reviewed Jun 29, 2024

View reviewed changes

PR fb

99c18f2

microsoft-github-policy-service bot added the emitter:client:csharp label Jun 29, 2024

JoshLove-msft added 2 commits June 28, 2024 19:44

Merge branch 'main' of https://github.com/microsoft/typespec into spl…

ec28af3

…it-out-plugins

fix build

cf2b43d

JoshLove-msft enabled auto-merge June 29, 2024 19:37

JoshLove-msft added 3 commits June 29, 2024 19:40

wip

33a229d

Add simple tracing example

98ce316

add todo

da84462

JoshLove-msft added 13 commits June 30, 2024 13:19

use snippet

5057347

Only trace protocol methods

dbe2da3

make internal

f6c7360

Remove dist-test workaround

6dd8c02

Clean up plugin

6ab60bc

Add expression conversion method

a70b215

docs

1a3bdd4

fix

f05de8a

Fix casing

a0e4955

Remove unused files

c5ec514

extract method

a9184a5

remove TODO

2e0d81a

add method name

9977a8d

JoshLove-msft mentioned this pull request Jul 1, 2024

Fix indentation in TryCatchFinallyStatement #3706

Merged

remove rootnamespace property

29ad896

m-nash reviewed Jul 1, 2024

View reviewed changes

github-merge-queue bot pushed a commit that referenced this pull request Jul 1, 2024

Fix indentation in TryCatchFinallyStatement (#3706)

09e3c6c

Found while working on #3698

PR fb

e81eaee

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test plugin #3698

Add test plugin #3698

JoshLove-msft commented Jun 28, 2024 •

edited

Loading

m-nash Jun 29, 2024

JoshLove-msft Jun 29, 2024

m-nash Jul 1, 2024

JoshLove-msft Jul 1, 2024

azure-sdk commented Jun 29, 2024

azure-sdk commented Jun 30, 2024

m-nash Jul 1, 2024

m-nash Jul 1, 2024

m-nash Jul 1, 2024

m-nash Jul 1, 2024

Add test plugin #3698

Are you sure you want to change the base?

Add test plugin #3698

Conversation

JoshLove-msft commented Jun 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azure-sdk commented Jun 29, 2024

azure-sdk commented Jun 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoshLove-msft commented Jun 28, 2024 •

edited

Loading