Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA "p" releases are not being found #35

Closed
NullEntity opened this issue Feb 11, 2018 · 2 comments
Closed

QA "p" releases are not being found #35

NullEntity opened this issue Feb 11, 2018 · 2 comments
Assignees
Labels

Comments

@NullEntity
Copy link

NullEntity commented Feb 11, 2018

PS C:\Users\bryce> Find-UnitySetupInstaller -Version 2017.3.0p4 -Components Setup
Could not find archives for Unity version 2017.3.0p4
At C:\Users\bryce\OneDrive\Documents\WindowsPowerShell\Modules\UnitySetup\2.1.43\UnitySetup.psm1:204 char:9
+         throw "Could not find archives for Unity version $Version"
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Could not find ...sion 2017.3.0p4:String) [], RuntimeException
    + FullyQualifiedErrorId : Could not find archives for Unity version 2017.3.0p4

It seems to fail on any "p" releases. I got the version numbers from the Patch Releases page. Other release types seem to be working correctly.

@NullEntity
Copy link
Author

It looks to me like this line should be -ne. I changed it in a local copy and it seems to find the version info properly now.
https://github.com/Microsoft/unitysetup.powershell/blob/develop/UnitySetup/UnitySetup.psm1#L199

@jwittner
Copy link
Member

Thanks! There was another issue in there too. PR is up for moving fix into develop. Next release to master should happen this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants