Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in CONTROL files #14787

Closed
gvanem opened this issue Nov 26, 2020 · 3 comments · Fixed by #14794
Closed

Typos in CONTROL files #14787

gvanem opened this issue Nov 26, 2020 · 3 comments · Fixed by #14794
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@gvanem
Copy link

gvanem commented Nov 26, 2020

A quick search through the CONTROL files shows these libary typos:

  • ports\ebml\CONTROL: Description: a C++ libary to parse EBML files
  • ports\gppanel\CONTROL: Description: gpPanel is chart libary for wxWidget. It inheritance from wxPanel and ...
  • ports\matroska\CONTROL: Description: a C++ libary to parse Matroska files (.mkv and .mka)
  • ports\polyhook2\CONTROL: Description: C++17, x86/x64 Hooking Libary v2.0
  • ports\unrar\CONTROL: Description: rarlab's unrar libary

Should be easy to fix.

@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Nov 26, 2020
@NancyLi1013 NancyLi1013 self-assigned this Nov 26, 2020
@NancyLi1013
Copy link
Contributor

Hi @gvanem

Thanks for posting this issue.

We will update these typos later.

@gvanem
Copy link
Author

gvanem commented Nov 26, 2020

And what about composable? Used in:

  • ports\bfgroup-lyra\CONTROL: Description: A simple to use, composable, command line parser for C++ 11 and beyond
  • ports\wangle\CONTROL: Description: Wangle is ... building services in a consistent, modular, and composable way.

Yuk!

@vicroms
Copy link
Member

vicroms commented Nov 26, 2020

The instances of "composable" come directly from the upstream library descriptions.

As a matter of policy, we don't usually accept PRs whose only purpose is to fix typos:

https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#avoid-trivial-changes-in-untouched-files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants