Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect triplet configuration for Project Reunion sample app #15409

Closed
soumyamahunt opened this issue Jan 1, 2021 · 0 comments · Fixed by #15410
Closed

Incorrect triplet configuration for Project Reunion sample app #15409

soumyamahunt opened this issue Jan 1, 2021 · 0 comments · Fixed by #15410
Assignees
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@soumyamahunt
Copy link
Contributor

soumyamahunt commented Jan 1, 2021

Describe the bug
The Project Reunion Hello World sample shows a C++ sample that demonstrates some ProjectReunion APIs. Using vcpkg for this project, the VcpkgOSTarget is incorrectly detected as uwp instead of windows.

Environment

  • OS: Windows
  • Compiler: revision

To Reproduce
Steps to reproduce the behavior:

  1. Download the Reunion Hello World Sample.
  2. Open the project in Visual Studio.
  3. Create a vcpkg manifest file in the project directory and declare some dependencies.
  4. Build solution and notice the triplet chosen in build log.

Expected behavior
On looking into vcpkg.props file, VcpkgOSTarget is set to uwp when ApplicationType is Windows Store and ApplicationTypeRevision is 10.0. Both holds true for the reunion sample. Instead AppContainerApplication should be checked and VcpkgOSTarget will be set to uwp only if AppContainerApplication is true. Use this:

<VcpkgOSTarget Condition="'$(AppContainerApplication)' == 'true'">uwp</VcpkgOSTarget>

instead of this:

<VcpkgOSTarget Condition="'$(ApplicationType)|$(ApplicationTypeRevision)' == 'Windows Store|10.0'">uwp</VcpkgOSTarget>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants