vcpkg_cmake_configure does not change the cwd on windows

[autoantwort]

While working on #21168 the following was detected:
It seems that vcpkg_cmake_configure does not change the cwd in contrast to vcpkg_configure_cmake on windows.
The line file(MAKE_DIRECTORY generated) generates the following error on windows but not on other platforms:

CMake Error at CMakeLists.txt:13 (file):
  file attempted to create a directory:
  C:/Users/LeanderSchulten/git_projects/vcpkg/buildtrees/offscale-libetcd-cpp/src/fdb87cf638-60a9ea69fd.clean/generated
  into a source directory.

[JackBoosY]

@strega-nil-ms can you please take a look?

I met this error also.

[JackBoosY]

According to cmake issue https://gitlab.kitware.com/cmake/cmake/-/issues/18811,
The reason why we got this error is CMAKE_DISABLE_SOURCE_CHANGES is enabled.
I will check the maintain history later.

[JackBoosY]

Additional. we can use option DISABLE_PARALLEL_CONFIGURE to vcpkg_configure_cmake / vcpkg_cmake_configure to avoid this.

[JackBoosY]

This option was introduced by PR #12846.

[dg0yt]

This analysis went in the wrong direction again. The problem is entirely in vcpkg_cmake_configure (and vcpkg_configure_cmake) which invokes cmake differently (from ninja) with parallel configure. It is more evident with the port version because it uses parallel by default.

[dg0yt]

While working on #21168 the following was detected: It seems that vcpkg_cmake_configure does not change the cwd in contrast to vcpkg_configure_cmake on windows. The line file(MAKE_DIRECTORY generated) generates the following error on windows but not on other platforms:

CMake Error at CMakeLists.txt:13 (file):
  file attempted to create a directory:
  C:/Users/LeanderSchulten/git_projects/vcpkg/buildtrees/offscale-libetcd-cpp/src/fdb87cf638-60a9ea69fd.clean/generated
  into a source directory.

What can be fixed is:
Change the cwd for uniform behaviour between parallel and non-parallel configure.

What can't be fixed is:
Enable (parallel!) safe writes to the source directory during parallel configure.

[dg0yt]

For parallel configure to work, offscale-libetcd-cpp must be patched. Cf. #22124 (comment).

[strega-nil-ms]

Yeah, this is not a bug (as @dg0yt points out) - offscale-libetcd-cpp cannot use parallel configure.

[dg0yt]

It is a bug because it affects the working directory of execute_process, and a patch is pending in #22124.

[strega-nil-ms]

mmh, okay, thanks! reopening