Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libmt32emu] add a CMake config file to esay integrate in a CMake project #22273

Closed
Raffaello opened this issue Dec 31, 2021 · 3 comments
Closed
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision

Comments

@Raffaello
Copy link


Is your feature request related to a problem? Please describe.
I have notice that the libmt32emu does not have a CMake config file, but it looks like it should come with one:
https://github.com/munt/munt/blob/master/mt32emu/cmake/MT32EmuConfig.cmake.in

Proposed solution
like all other vcpkg managed dependencies, would be nice to have a cmake to easily include the library in a CMake project,
as well, eventually, after installed it, display a message how to include it in CMake.

Describe alternatives you've considered
At the moment i haven't tried any alternatives, but it will be to include the package manually or using it outside vcpkg.

Additional context
vcpkg install --triplet x64-windows libmt32emu

after succesfully installed the pacakge, there is no cmake configuration file to easily use it.

@Hoikas
Copy link
Contributor

Hoikas commented Dec 31, 2021

Version 2.5.3 (which is what is used by vcpkg) does not have CMake configs. Upstream needs to release a new version for us to have the config.

@JackBoosY JackBoosY added depends:upstream-changes Waiting on a change to the upstream project category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Jan 1, 2022
@JackBoosY JackBoosY added category:port-update The issue is with a library, which is requesting update new revision and removed depends:upstream-changes Waiting on a change to the upstream project labels Jul 29, 2022
@JackBoosY
Copy link
Contributor

I believe this issue can be resolved by updating to the new version.

@Raffaello
Copy link
Author

I believe this issue can be resolved by updating to the new version.

yes i believe so too.
I have just updated to the latest mt32lib with latest vcpkg.

and the CMake config is available in
\vcpkg\packages\libmt32emu_x64-windows\share\MT32Emu\ folder

I dind't have time yet to integrate in a project to use it, but if i recall correctly, it was not existing at all after a vcpkg install.

So i am cofident this issue is resolved.
thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

No branches or pull requests

3 participants