Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proxy information from Windows when downloading files #252

Closed
ras0219-msft opened this issue Nov 3, 2016 · 3 comments
Closed

Use proxy information from Windows when downloading files #252

ras0219-msft opened this issue Nov 3, 2016 · 3 comments
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed

Comments

@ras0219-msft
Copy link
Contributor

Currently, portfiles use CMake's built-in downloading function to acquire sources. This function is backed by curl, which doesn't use Windows' system-wide proxy settings and instead requires special environment variables (http_proxy, https_proxy, ftp_proxy, ...).

Inside vcpkg.exe, we should detect the Windows settings and fill in these environment variables before calling CMake so users get a much cleaner out-of-the-box experience.

@ras0219-msft ras0219-msft added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Nov 3, 2016
@KindDragon
Copy link
Contributor

Inside vcpkg.exe, we should detect the Windows settings and fill in these environment variables before calling CMake so users get a much cleaner out-of-the-box experience.

But in this case, the user will still have to specify a username and password?

@ras0219-msft
Copy link
Contributor Author

Perhaps; curl will use the username/password information from the environment variable so we could prompt for credentials (or, more nicely, take it from a command line argument/config file).

@PhoebeHui
Copy link
Contributor

I think microsoft/vcpkg-tool#49 has implemented this, @ras0219-msft, please reopen this issue if i'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
Development

No branches or pull requests

3 participants