Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clipp] Integrate C++20 compile fix from project's pull request #27167

Closed
DominikGrabiec opened this issue Oct 10, 2022 · 1 comment · Fixed by #27218
Closed

[clipp] Integrate C++20 compile fix from project's pull request #27167

DominikGrabiec opened this issue Oct 10, 2022 · 1 comment · Fixed by #27218
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project

Comments

@DominikGrabiec
Copy link

I've got an issue with the clipp library where it does not compile with C++20 and I wanted to submit a pull request for fixing it by using a patch, but on the pull request screen suggested creating an issue to discuss the problem & solution so here I am.

The Problem
Currently the clipp library does not compile with C++20 (at least on Visual Studio 2022) because it uses deprecated functions. There's an open pull request on the project which fixes this but the project itself hasn;'t been updated in many years. (Note I'm not blaming the project owner or expecting anything).

Proposed solution
The patch in the project's pull request works and I've tested it locally by adding it to the ports/clipp/ directory and then referencing it from ports/clipp/portfile.cmake.

This seems like the most light weight solution since we're not forking the project or anything. However I can see potential issues such as incompatability with older C++ standards and other compilers.

Question
So is adding this patch (or some similar patch with more #ifdefs) to fix the C++20 build issue something resonable that vcpkg would want to do or is it outside the scope of this project and people should do that manually?

@Cheney-W Cheney-W added the depends:upstream-changes Waiting on a change to the upstream project label Oct 11, 2022
@Cheney-W
Copy link
Contributor

Normally, this problem should have been fixed by upstream, but it looks like upstream is not maintained anymore, so I think we can add a patch to vcpkg to fix it.

@Cheney-W Cheney-W added the category:port-bug The issue is with a library, which is something the port should already support label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants