Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libigl:x64-windows] can't compile canonical example due to missing header. #31162

Closed
volumeDigital opened this issue Apr 28, 2023 · 5 comments
Closed
Assignees
Labels
category:question This issue is a question

Comments

@volumeDigital
Copy link

volumeDigital commented Apr 28, 2023

Describe the bug

Installation of libigl not sufficient to compile the canonical libigl example.

Many headers from libigl don't appear to be installed, including igl/opengl/glfw/Viewer.h

Environment

  • OS: Windows 10 Pro 22H2 19045.2846
  • Compiler: Microsoft (R) C/C++ Optimizing Compiler Version 19.35.32217.1 for x64

To Reproduce

  1. vcpkg install libigl[*]
  2. Create blank C++ project using Microsoft Visual Studio Community 2022 (64-bit) - Current Version 17.5.4
  3. Create a main.cpp with
#include <igl/opengl/glfw/Viewer.h>

int main(int argc, char* argv[])
{
	return 0;
}
  1. Attempt to build

Expected behavior

Build to succeed.

Failure logs
Error C1083 Cannot open include file: 'igl/opengl/glfw/Viewer.h': No such file or directory

Additional context

  • Have enabled integrations, they work fine for other packages (Eigen/raylib)
  • Also tried for x86-windows, same problem.
@volumeDigital
Copy link
Author

volumeDigital commented Apr 29, 2023

Rolled back to #475954aaa (last commit using libigl 2.3.0, and just before 2.4.0 is introduced) and installed only with opengl and glfw features -> Viewer.h is installed as expected, and code above compiles.

@volumeDigital volumeDigital changed the title libigl:x64-windows: can't compile canonical example due to missing header. [libigl:x64-windows] can't compile canonical example due to missing header. Apr 29, 2023
@volumeDigital
Copy link
Author

The commit that introduces 2.4.0 (3fce2d) isn't currently buildable, as it predates PR #30546

Adjusting to use msys2-runtime-3.2.0-15 - which is still available on mirror - makes 3fce2d buildable.

Once built, we can see Viewer.h is not installed, and so this is the commit that introduces the issue.

@dg0yt
Copy link
Contributor

dg0yt commented Apr 29, 2023

The commit that introduces 2.4.0 (3fce2d) isn't currently buildable, as it predates PR #30546

Use manifest mode, or use a copy of the old port version as overlay port.

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support category:question This issue is a question and removed category:port-bug The issue is with a library, which is something the port should already support labels May 4, 2023
@jimwang118
Copy link
Contributor

The commit that introduces 2.4.0 (3fce2d) isn't currently buildable, as it predates PR #30546

Adjusting to use msys2-runtime-3.2.0-15 - which is still available on mirror - makes 3fce2d buildable.

Once built, we can see Viewer.h is not installed, and so this is the commit that introduces the issue.

This is because the upstream does not provide the Viewer.h header file after version 2.4.0, please use this port as suggested by dg0yt.

@jimwang118
Copy link
Contributor

We hope your question was answered to your satisfaction; if it wasn't, you can reopen with more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:question This issue is a question
Projects
None yet
Development

No branches or pull requests

3 participants