Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angle] don't link to frameworks with absolute path #32782

Closed
daschuer opened this issue Jul 27, 2023 · 1 comment · Fixed by #32890
Closed

[angle] don't link to frameworks with absolute path #32782

daschuer opened this issue Jul 27, 2023 · 1 comment · Fixed by #32890
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@daschuer
Copy link
Contributor

Is your feature request related to a problem? Please describe.

angle suffers from #16259

see unofficial-angle-targets.cmake

set_target_properties(unofficial::angle::libGLESv2 PROPERTIES
  INTERFACE_LINK_LIBRARIES "\$<LINK_ONLY:unofficial::angle::libANGLE>;/Applications/Xcode_12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/CoreGraphics.framework;/Applications/Xcode_12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/Foundation.framework;/Applications/Xcode_12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/IOKit.framework;/Applications/Xcode_12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/IOSurface.framework;/Applications/Xcode_12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/Quartz.framework"
)

Proposed solution

The best would be an upstream patch, but I don't know how to do it. Since it is an "unofficial" cmake config file, the issue will be hard to discuss with upstream.

Describe alternatives you've considered

The alternative would be patching the unofficial-angle-targets.cmake after creation.

Additional context

No response

@daschuer daschuer added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 27, 2023
@daschuer daschuer changed the title [angle] don't link to frameworks with abssolute path [angle] don't link to frameworks with absolute path Jul 27, 2023
@JackBoosY
Copy link
Contributor

I think we have a same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants