Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dp-thread-pool 0.6.2] The include folder name includes the version #34140

Open
cosmin42 opened this issue Sep 29, 2023 · 2 comments
Open

[dp-thread-pool 0.6.2] The include folder name includes the version #34140

cosmin42 opened this issue Sep 29, 2023 · 2 comments
Assignees
Labels
depends:upstream-changes Waiting on a change to the upstream project

Comments

@cosmin42
Copy link

Is your feature request related to a problem? Please describe.

When installing dp-thread-pool the include path is
vcpkg\installed\x64-windows\include\thread-pool-0.6.2
It should be:
vcpkg\installed\x64-windows\include

When using the library, the include path has to be added manually which should not be necessary.

Proposed solution

CONFIG_PATH lib/cmake/thread-pool-${VERSION}

Change CONFIG_PATH lib/cmake/thread-pool-${VERSION} to CONFIG_PATH lib/cmake/thread-pool

Describe alternatives you've considered

No response

Additional context

Machine: Reproduced on windows-x64, but it's not specific.

Steps to reproduce:

  1. vcpkg install dp-thread-pool:x64-windows
  2. Go to vcpkg\installed\x64-windows\include

Expected: thread-pool exists.
Actual: thread-pool-0.6.2 exists.

@cosmin42 cosmin42 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 29, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Sep 30, 2023

When installing dp-thread-pool the include path is
vcpkg\installed\x64-windows\include\thread-pool-0.6.2
It should be:
vcpkg\installed\x64-windows\include

Upstream chose first.

Change CONFIG_PATH lib/cmake/thread-pool-${VERSION} to CONFIG_PATH lib/cmake/thread-pool

This doesn't affect include.
But the CMake config has the full path:

set_target_properties(dp::thread-pool PROPERTIES
  ...
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include/thread-pool-0.6.2"
  ...
)

If you don't use CMake, you may need to configure manually,

Copy link

github-actions bot commented Apr 5, 2024

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Apr 5, 2024
@Cheney-W Cheney-W added depends:upstream-changes Waiting on a change to the upstream project and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Apr 7, 2024
@github-actions github-actions bot removed the Stale label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Development

No branches or pull requests

3 participants